New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-cleaning integration tests #2497
base: develop
Are you sure you want to change the base?
Self-cleaning integration tests #2497
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Quickstart template updates in |
… of https://github.com/zenml-io/zenml into bugfix/OSSK-471-make-clean-client-with-rst-great-again
Describe changes
I implemented logic to clean-up after all tests we run in
tests/integration
folder and removedclean_client
where it was used, so tests are running really on REST and not on SQL.This highlighted a couple of bugs, which were fixed along the way:
delete_deployment
There is instability in parallel objects creation tests on REST, but this is not worth fixing here - we need to work on UC in separate PR instead.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes