Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax azure, gcfs and s3 dependencies #2498

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Mar 6, 2024

This pull request updates the version requirements for the azure, gcfs, and s3 dependencies to allow for more flexibility in the versions used.

In particular, this would unblock #2376.

@strickvl strickvl added the internal To filter out internal PRs and issues label Mar 6, 2024
@strickvl strickvl requested a review from stefannica March 6, 2024 15:56
@strickvl strickvl added the dependencies Pull requests that update a dependency file label Mar 6, 2024
@strickvl strickvl requested a review from safoinme March 6, 2024 15:56
Copy link
Contributor

coderabbitai bot commented Mar 6, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@strickvl strickvl requested review from avishniakov and removed request for stefannica March 6, 2024 16:05
@strickvl
Copy link
Contributor Author

strickvl commented Mar 6, 2024

@stefannica just drawing your attention to this since I think a few of these restrictions were originally set by you. I have little sense of the consequence of relaxing the dependencies, but we need to find a way to allow for the huggingface_hub installation somehow and this was the path I found that seems to work...

Copy link
Contributor

@avishniakov avishniakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@stefannica
Copy link
Contributor

@stefannica just drawing your attention to this since I think a few of these restrictions were originally set by you. I have little sense of the consequence of relaxing the dependencies, but we need to find a way to allow for the huggingface_hub installation somehow and this was the path I found that seems to work...

IIRC, one of the reasons why I pinned down boto3 was to speed up the pip dependency resolution. But that's no longer an issue, so this should be good to go.

@strickvl strickvl merged commit b13c8d5 into develop Mar 7, 2024
64 checks passed
@strickvl strickvl deleted the misc/relax-fsspec-dependencies branch March 7, 2024 11:13
adtygan pushed a commit to adtygan/zenml that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal To filter out internal PRs and issues run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants