-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax azure, gcfs and s3 dependencies #2498
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@stefannica just drawing your attention to this since I think a few of these restrictions were originally set by you. I have little sense of the consequence of relaxing the dependencies, but we need to find a way to allow for the huggingface_hub installation somehow and this was the path I found that seems to work... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦭
IIRC, one of the reasons why I pinned down boto3 was to speed up the pip dependency resolution. But that's no longer an issue, so this should be good to go. |
This pull request updates the version requirements for the azure, gcfs, and s3 dependencies to allow for more flexibility in the versions used.
In particular, this would unblock #2376.