Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct validity for EKS API tokens and handle long-running Kubernetes pipelines #2589

Merged
merged 12 commits into from
Apr 9, 2024

Conversation

stefannica
Copy link
Contributor

@stefannica stefannica commented Apr 5, 2024

Describe changes

This PR addresses two problems:

  1. the Kubernetes API tokens issued by the AWS Service Connector for EKS clusters had an incorrect TTL period of 60 minutes instead of 15 minutes as documented by AWS (source)
  2. the shorter TTL causes problems when running Kubernetes orchestrated pipelines that take longer to build container images or take longer than 15 minutes to run.

Side-changes:

  • some orchestrators, the Kubernetes orchestrator included, incorrectly instantiate the service connector they are linked to in the stack validation phase. This is not necessary and has the side effect that the connector credentials are generated before the container images are built and pushed. In the context of this PR, it is partially responsible for the expiration of credentials before the pipeline is triggered, because building and pushing container images can take longer than 15 minutes.
  • this PR also fixes a bug that slipped through in Try/catch for Docker client #2513 that no longer allowed Docker credentials to be pulled from service connectors when building images for containerized pipelines. NOTE: if the container registry is linked to a service connector one does not need to run docker login to authenticate the docker client anymore.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@stefannica stefannica requested a review from safoinme April 5, 2024 17:00
Copy link
Contributor

coderabbitai bot commented Apr 5, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Apr 5, 2024
@stefannica stefannica marked this pull request as ready for review April 5, 2024 17:41
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Quickstart template updates in examples/quickstart have been pushed.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

@stefannica stefannica force-pushed the bug/ossk-504-fix-eks-service-connector-expiry branch from d8260a8 to f172a03 Compare April 5, 2024 18:35
@stefannica stefannica force-pushed the bug/ossk-504-fix-eks-service-connector-expiry branch from f172a03 to 1006810 Compare April 5, 2024 18:36
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Quickstart template updates in examples/quickstart have been pushed.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

@stefannica stefannica merged commit 7a4632f into develop Apr 9, 2024
56 checks passed
@stefannica stefannica deleted the bug/ossk-504-fix-eks-service-connector-expiry branch April 9, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants