Added lightgbm integration #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
strickvl
reviewed
Apr 26, 2022
schustmi
requested changes
Apr 26, 2022
docs/book/features/integrations.md
Outdated
| @@ -41,6 +41,7 @@ These are the third-party integrations that ZenML currently supports: | |||
| | Hugging Face | ✅ | Materializer | Use Hugging Face tokenizers, datasets and models. | [huggingface](https://github.com/zenml-io/zenml/tree/main/examples/huggingface) | | |||
| | KServe | ⛏ | Inference | Looking for community implementors. | | | |||
| | Kubeflow | ✅ | Orchestrator | Either full Kubeflow or Kubeflow Pipelines. Works for local environments currently. | [kubeflow](https://github.com/zenml-io/zenml/tree/main/examples/kubeflow) | | |||
| | lightgbm | ✅ | Training | Support for `Booster` and `Dataset` materialization. | [xgboost](https://github.com/zenml-io/zenml/tree/main/examples/lightgbm) | | |||
There was a problem hiding this comment.
still has some xgboost references in there
|
|
||
| # Make a temporary phantom artifact | ||
| with tempfile.NamedTemporaryFile( | ||
| mode="w", suffix=".json", delete=True |
There was a problem hiding this comment.
Not that it will break anything, but I'm a little confused why the suffix is .json here and the default filename is model.txt?
There was a problem hiding this comment.
Its a copy pasta! Fixed now!
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
I added lightgbm integration as i thought it was a quick win after xgboost. Its basically the same with some caveats as #538!
Pre-requisites
Please ensure you have done the following:
Types of changes