-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Keras materializer to work with remote artifact stores #569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a cool change 🚀. I'm unsure whether the PR title is accurate though. It not only works with Azure store but also all remote stores now right?
@@ -119,7 +122,7 @@ def visualize_statistics(): | |||
# Run the pipeline | |||
p = boston_housing_pipeline( | |||
importer=importer(), | |||
trainer=trainer(), | |||
trainer=trainer().with_return_materializers(KerasMaterializer), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's for every remote storage.
Sorry I will remove it, we don't need it actually
src/zenml/integrations/tensorflow/materializers/keras_materializer.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing changes. Everything looks great
Describe changes
Change the Keras model materializer to support the Azure artifact store. By saving the model in a temp file then use fileio to copy it to remote storage.
Pre-requisites
Please ensure you have done the following:
Types of changes