Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

Increase number of significant digits and/or make them controllable #867

Open
1 of 3 tasks
neubig opened this issue Jun 21, 2023 · 3 comments
Open
1 of 3 tasks

Increase number of significant digits and/or make them controllable #867

neubig opened this issue Jun 21, 2023 · 3 comments

Comments

@neubig
Copy link
Contributor

neubig commented Jun 21, 2023

Zeno rounds metric values to two decimal places before displaying them. This might be a bit too aggressive (usually there are 3 or 4 significant digits reported in papers).

I also think it might be a good idea to do rounding right before we print any numbers, but not before we create figures. I can't think of any reason to reduce the granularity of bar height for example.

We could consider:

  • Making the default 4 instead of 2
  • Making this value controllable through ZenoOptions
  • Make rounding happen right before text is printed, but don't apply rounding when determining other things like bar height in a bar chart

Below is a specific example where rounding to significant digits is locking in the height on visualizations:
visualization (2)

@neubig neubig changed the title Modify significant digits and/or make controllable Increase number of significant digits and/or make controllable Jun 21, 2023
@neubig neubig changed the title Increase number of significant digits and/or make controllable Increase number of significant digits and/or make them controllable Jun 21, 2023
@Sparkier
Copy link
Member

Sparkier commented Jun 22, 2023

#868 Fixes the third bullet but we should keep this open for the other two.

@neubig
Copy link
Contributor Author

neubig commented Jun 22, 2023

Thanks for the quick PR @Sparkier! Actually for the third bullet, on bar charts (or other similar charts) it'd be nice to round the textual labels but not lock in the bar height. The labels are a bit verbose now:

visualization (3)

@Sparkier
Copy link
Member

Thanks for the quick PR @Sparkier! Actually for the third bullet, on bar charts (or other similar charts) it'd be nice to round the textual labels but not lock in the bar height. The labels are a bit verbose now:

visualization (3)

Should be fixed in #869

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants