Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move type definitions to DefinitelyTyped #395

Closed
3 tasks
alexkrolick opened this issue Aug 7, 2018 · 4 comments
Closed
3 tasks

Move type definitions to DefinitelyTyped #395

alexkrolick opened this issue Aug 7, 2018 · 4 comments

Comments

@alexkrolick
Copy link
Collaborator

alexkrolick commented Aug 7, 2018

No maintainers update the typescript definitions directly and they are a frequent source of bugs, so I'd like to move them out of the repo to a 3rd party source.

https://twitter.com/drosenwasser/status/1024474677798887424

We should end up with something like this: testing-library/react-testing-library#437

  • Create react-quill on DefinitelyTyped
  • Remove local TS definitions
  • Install DT package as a dependency to enable automatic type acquisition in TS/VSCode
@zenoamaro zenoamaro unpinned this issue Mar 29, 2020
@vdh
Copy link

vdh commented Apr 2, 2020

Could you either finish this export or pull one of the PRs? Because as is the types are just broken.

@alexkrolick
Copy link
Collaborator Author

The TS rewrite supercedes this ticket, closing. @vdh can you check out the beta release?

@vdh
Copy link

vdh commented Apr 3, 2020

@alexkrolick Thanks, the v2 version solves the import issues I was having with the types inside the namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants