Removing obsolete redirection #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Jun 5, 2023
| @@ -221,10 +221,6 @@ | |||
| "source": "/communities/<community_id>/curate", | |||
| "target": communities_requests_view_function, | |||
| }, | |||
| "redirect_communities_about": { | |||
There was a problem hiding this comment.
not sure this was obsolete, can someone confirm, ping @alejandromumo @slint ?
There was a problem hiding this comment.
Ok, after some memory loss, I found #336. Which means that this redirect is not needed anymore, we do actually serve a page there that is valid.
slint
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to close inveniosoftware/invenio-app-rdm#2217 and closes #336.
The redirection for communities//about doesn't seem to work. We could rely on the redirection from invenio-rdm, instead of having to redefine it in zenodo-rdm