Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata-extractor: extractor metadata modal #1254

Merged
merged 2 commits into from Aug 9, 2017

Conversation

xiaom
Copy link
Contributor

@xiaom xiaom commented Aug 9, 2017

There are some unresolved UI problems.

  1. Disable the apply button before the extraction is completed. ng-disabled does not work as I expected.
  2. Close the modal when I apply the changes. I use ng-click="applyMetadata();$hide()" in the code. But it seems $hide() is not executed.

@xiaom xiaom requested a review from krzysztof August 9, 2017 08:23
* Updated the extraction modal to support individual metadata application.

Signed-off-by: Krzysztof Nowak <k.nowak@cern.ch>
@krzysztof
Copy link
Contributor

I've pushed some minor fixes. Overall looks nice.

I encountered this error: inveniosoftware/invenio-files-processor#7
I can send you the file which causes this later.

  1. fixed - I am disabling each individual button.
  2. fixed - I don't close the modal at all since now there's multiple buttons. the user is supposed to close it with a "Close" button. But strangely - even before the changes the modal was closing for me ...

@krzysztof krzysztof merged commit 0b75c59 into zenodo:metadata_extraction Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants