iiif thumbnail precaching #1697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
approved these changes
Feb 6, 2019
zenodo/modules/records/tasks.py
Outdated
| @@ -27,6 +27,7 @@ | |||
| from __future__ import absolute_import, print_function | |||
|
|
|||
| from datetime import datetime | |||
| import arrow | |||
There was a problem hiding this comment.
I guess something was moved from here, so these imports are unecessary.
| @@ -0,0 +1,27 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
I think a better name for the sub-module would be zenodo.modules.iiif (since we're adding IIIF functionality)
zenodo/modules/thumbnails/tasks.py
Outdated
| ).source(include=['_files'])) | ||
| records_files = q.scan() | ||
| for record_files in records_files: | ||
| for object_file in record_files.to_dict()['_files']: |
There was a problem hiding this comment.
Suggested change
| for object_file in record_files.to_dict()['_files']: | |
| for object_file in record_files.to_dict().get('_files', []): |
zenodo/modules/thumbnails/tasks.py
Outdated
| records_files = q.scan() | ||
| for record_files in records_files: | ||
| for object_file in record_files.to_dict()['_files']: | ||
| if(object_file['type'] not in ['jpg', 'png', 'tif', 'tiff']): |
There was a problem hiding this comment.
Suggested change
| if(object_file['type'] not in ['jpg', 'png', 'tif', 'tiff']): | |
| if(object_file.get('type') not in ['jpg', 'png', 'tif', 'tiff']): |
zenodo/modules/thumbnails/tasks.py
Outdated
| for object_file in record_files.to_dict()['_files']: | ||
| if(object_file['type'] not in ['jpg', 'png', 'tif', 'tiff']): | ||
| continue | ||
| size = '250,' # flask_iiif doesn't support ! at the moment |
There was a problem hiding this comment.
I think we don't need ! anyways, the w, is fine
Glignos
force-pushed
the
iiif_fixed_branch
branch
from
836fada
to
17b07ee
Compare
ChiaraBi
force-pushed
the
iiif_fixed_branch
branch
10 times, most recently
from
82b8b55
to
dc395a8
Compare
|
Tests are failing with Python 3.5 because here the key gets encoded. We should make a PR to |
ChiaraBi
force-pushed
the
iiif_fixed_branch
branch
from
dc395a8
to
5556a37
Compare
Glignos
force-pushed
the
iiif_fixed_branch
branch
from
5556a37
to
d359ea7
Compare
Glignos
force-pushed
the
iiif_fixed_branch
branch
from
d359ea7
to
60d4c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.