-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port of rtmfp-cpp to vcpkg #13
Comments
i'm not familiar with this project. it looks like you're referencing the latest commit of how are these entries in vcpkg maintained? to people audit it from time-to-time to see if there are new versions of packages available? or do the people who add packages implicitly volunteer to keep them up-to-date? |
We have to do it manually! And by the way your library is only working on Linux but also compiles well on Windows. Is there any possibility to make the network adapter work with Windows? |
It is very simple to port any library to vcpkg just have a look at the commit history for that pull request and you can see that it all fits in almost 4 files. |
First you need to clone vcpkg and after fork the repo in your own repo with new branch like I did : https://github.com/as-shura/vcpkg/tree/rtmfp-cpp And once you tested the vcpkg install rtmfp-cpp:x64-windows command on your local system then you can ask for a pull request. |
i haven't personally used CMake on anything but Linux, but the library builds (and all test programs run) with its Makefile on Linux, MacOS, and FreeBSD. i'll validate using CMake on a Mac and fix it if that's broken.
as i stated in the README, Windows isn't "officially supported", and i have no plans to implement a Windows platform adapter or add one to the library. however, i'm more than happy to link to any community-provided Windows platform adapter and utility packages, and those packages might also be good candidates to add to vcpkg. |
What do I need to know to be able to understand how to implement the Windows adapter? From what I know Flash was working on Windows with the RTMFP protocol. What is the reason you decided to not support Windows? Or is it a lack of Network programming knowledge on that platform? |
i'm not supporting Windows because i don't have any Windows programming knowledge (especially networking, as well as the way one would want a platform adapter to naturally fit with the normal way one writes Windows applications). in addition, i don't have any Windows systems on which to develop and test (nor interest or time to allow Windows on any of my personal systems). this project is a labor of love for me, for which i have limited time, and Windows is at the bottom of my personal priorities. again, if there's interest in the community to develop and maintain Windows adapters, i'm happy to link to them.
while i also wrote the original implementation of RTMFP that's in Flash Player (and Adobe Media Server), this library is a completely new and different implementation based on the RFC 7016 public spec (which i also wrote ;) ). similarly to this implementation though, the Flash implementation abstracted the "platform" via adapters, and other developers with OS-specific knowledge adapted the portable base protocol implementation to the different operating systems Flash Player ran on, and that worked naturally in the architecture of Flash Player.
you need to understand Windows network programming, Windows event-based programming, the normal ways one writes event-based non-blocking programs on Windows, how you want to interface between your app and the network, etc. you would probably need something similar to a RunLoop and something similar to Performer working in a way natural for Windows programs, and then make a Windows RTMFP platform adapter within that framework. i suggest reading my |
i used
to build a test program with |
We have a compilation error when trying to build for Linux.
See microsoft/vcpkg#29442 |
interesting. i'll fix those. |
latest commit df7077d should fix those. i haven't seen those problems on any of my other builds. is that g++ or Clang (assuming g++ because |
but please use the actual latest commit 18168ec which has another fix for a Clang warning i just found. |
Good news everything is working!microsoft/vcpkg#29442 |
i left a comment on that PR: i think you need to switch to using |
after more comments in that PR from a contributor, it looks like you need to have |
Good done! Thank you for your help. |
microsoft/vcpkg#29442
The text was updated successfully, but these errors were encountered: