[rtmfp-cpp] Added rtmfp-cpp library #29442

as-shura · 2023-02-04T02:38:03Z

No description provided.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout f648140dbc5b73364021deac130daa99dd5eda8b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index b2a5c34..c3f1f90 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6868,6 +6868,10 @@
       "baseline": "2020-04-16",
       "port-version": 3
     },
+    "rtmfp-cpp": {
+      "baseline": "1.3.0",
+      "port-version": 0
+    },
     "rtmidi": {
       "baseline": "5.0.0",
       "port-version": 2

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/rtmfp-cpp/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/rtmfp-cpp/portfile.cmake

…mfp-cpp

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/rtmfp-cpp/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for rtmfp-cpp have changed but the version was not updated
version: 1.3.0
old SHA: 0d795ae2b23412c275c5a85cc7f35d991f3e5e5e
new SHA: fe02072ff6b83f7628cfa205f7063ae4cfc4e9ab
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/rtmfp-cpp/portfile.cmake

as-shura · 2023-02-04T17:26:03Z

Can someone explain to me what I need to do because I don't get it!

ports/rtmfp-cpp/portfile.cmake

Adela0814 · 2023-02-10T05:43:04Z

@as-shura Are you trying to fix the failures?
install-x64-linux-dbg-out.log

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/rtmfp-cpp/portfile.cmake

as-shura · 2023-02-10T11:30:33Z

@as-shura Are you trying to fix the failures? install-x64-linux-dbg-out.log

The log is empty there is nothing:

Adela0814 · 2023-02-14T09:21:32Z

Please try this one:
install-x64-linux-dbg-out.log

as-shura · 2023-02-14T21:42:49Z

Please try this one: install-x64-linux-dbg-out.log

I contacted the owner of code zenomt/rtmfp-cpp#13

as-shura · 2023-02-15T21:19:54Z

Contributor

Can retrigger a new compilation ?

zenomt · 2023-02-16T01:19:09Z

@as-shura

Can retrigger a new compilation ?

it doesn't look like you updated this PR to reference the latest commit in zenomt/rtmfp-cpp so a new compilation will have the same errors. i bet if you update the REF and push a new commit, it'll automatically trigger a new build.

as-shura · 2023-02-16T12:40:43Z

@as-shura

Can retrigger a new compilation ?

it doesn't look like you updated this PR to reference the latest commit in zenomt/rtmfp-cpp so a new compilation will have the same errors. i bet if you update the REF and push a new commit, it'll automatically trigger a new build.

I removed the REF_ID so that it take the master all the time.

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/rtmfp-cpp/portfile.cmake

zenomt · 2023-02-16T16:24:45Z

@as-shura according to the documentation for vcpkg_from_github, "REF ... This should not be a branch", but you specify "master". also, if REF is specified, SHA512 must also be specified (which it is in your latest commit).

this means that the next time i push any commit to master (main) in zenomt/rtmfp-cpp, this package will be broken.

based only on looking at that doc page, i think you want HEAD_REF instead of REF+SHA512.

ports/rtmfp-cpp/portfile.cmake

…mfp-cpp

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for rtmfp-cpp have changed but the version was not updated
version: 1.4.0-20230213.18168ec
old SHA: 826d147e14135574d243874924fddbc2a1721591
new SHA: c21433899bb0168f0573b148a2e38db27acabe66
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

zenomt · 2023-02-18T01:19:35Z

versions/r-/rtmfp-cpp.json

+    },
+    {
+      "git-tree": "e06da86339d4d4525090a61f90fab6aa0e2b61dc",
+      "version": "1.3.0",


since actual-release 1.3.0 is unlikely to work well (or at all) with vcpkg on all platforms, do you still want to leave 1.3.0 here?

This must be removed anyways. A PR can add just one entry.

@as-shura i don't understand why you marked this conversation "resolved" without taking the required action to remove the entry for version 1.3.0, so that this PR will add only one entry (for the correct version 1.4.0-20230213.18168ec)

zenomt · 2023-02-18T22:03:58Z

versions/r-/rtmfp-cpp.json

+      "version": "1.4.0-20230213.18168ec",
+      "port-version": 0
+    },
+    {


@dg0yt said
This must be removed anyways. A PR can add just one entry.

starting a new conversation for this since the previous one was marked "resolved" with no action. @as-shura please remove this extra section for version 1.3.0 because (1) apparently only one entry can be added per PR and (2) version 1.3.0 is unlikely to work as expected with vcpkg.

zenomt · 2023-02-20T00:07:20Z

hi @dg0yt and @Adela0814 , question for you both as people versed in vcpkg and its nuance: regarding the version specification in various files here, the vcpkg documentation is contradictory whether version is fully SemVer-compatible or not.

this page https://learn.microsoft.com/en-us/vcpkg/reference/vcpkg-json#version says that version is a

Relaxed Semantic Version 2.0.0, allowing more or less than 3 primary numbers. Example: 1.2.3.4.10-alpha1

where the example suggests that the full SemVer syntax including prerelease designator is allowed.

however, this page https://learn.microsoft.com/en-us/vcpkg/users/versioning#version says that version is a

relaxed, dot-separated-, semver-like scheme. The version is logically composed of dot-separated (.) numeric sections. Each section must contain an integer positive number with no leading zeroes. The regex pattern for this versioning scheme is: (0|[1-9]\d*)(\.(0|[1-9]\d*))*

The regex in particular indicates that the full SemVer syntax (including prerelease designators) isn't allowed. do you know which is correct? i'd hope that the first case (relaxed but full SemVer syntax and semantics including comparison and ordering) is actually supported, rather than the much more restrictive second case.

the purpose of this question is to determine if @as-shura should continue to use version, or if they should change to version-semver. staying with version seems preferable if that's appropriate.

dg0yt · 2023-02-21T17:51:16Z

the purpose of this question is to determine if @as-shura should continue to use version, or if they should change to version-semver. staying with version seems preferable if that's appropriate.

version, please. Unless upstream is strictly following semver.

JavierMatosD · 2023-02-23T20:17:03Z

When trying to install the port, it fails with the following:

Error: Failed to download from mirror set:
File does not have the expected hash:
url : [ https://github.com/zenomt/rtmfp-cpp/archive/v1.4.0-20230213.18168ec.tar.gz ]
File path : [ C:\dev\vcpkg\downloads\zenomt-rtmfp-cpp-v1.4.0-20230213.18168ec.tar.gz.22012.part ]

Expected hash : [eea3e4b52a4639dce3ff3f88011ae5b2f07dbeb7237f854b9b3f1a829c04af930c8edfa3a1a3cad95890a372fc6cc436b00c4dadf9b06fc404f50bdd36634a08 ]

Actual hash : [e83df63d01207300f53dcbece150e8c2db8630f19a5b477292285833ad3406a09037c3055181b9f67b6a6a0f528e1c36f72577c86451591161fd3ccd945f5841 ]

Additionally, I see two entries in the ports version file. There must only be one entry in the ports version file.

as-shura · 2023-02-25T15:42:20Z

Expected hash : [eea3e4b52a4639dce3ff3f88011ae5b2f07dbeb7237f854b9b3f1a829c04af930c8edfa3a1a3cad95890a372fc6cc436b00c4dadf9b06fc404f50bdd36634a08 ]

Actual hash : [e83df63d01207300f53dcbece150e8c2db8630f19a5b477292285833ad3406a09037c3055181b9f67b6a6a0f528e1c36f72577c86451591161fd3ccd945f5841 ]

This is what is in the port file :

vcpkg_from_github(
    OUT_SOURCE_PATH SOURCE_PATH
    REPO zenomt/rtmfp-cpp
    REF "v${VERSION}"
    SHA512 eea3e4b52a4639dce3ff3f88011ae5b2f07dbeb7237f854b9b3f1a829c04af930c8edfa3a1a3cad95890a372fc6cc436b00c4dadf9b06fc404f50bdd36634a08
    HEAD_REF main
)

zenomt · 2023-02-25T17:06:49Z

@as-shura the SHA512 hash in the port file is incorrect for the tag v1.4.0-20230213.18168ec. the error message is telling you "expected" (which is in the port file) doesn't match the actual (from downloading that tag as a .tgz file:

% curl -s -L https://github.com/zenomt/rtmfp-cpp/archive/v1.4.0-20230213.18168ec.tar.gz | openssl sha512
(stdin)= e83df63d01207300f53dcbece150e8c2db8630f19a5b477292285833ad3406a09037c3055181b9f67b6a6a0f528e1c36f72577c86451591161fd3ccd945f5841

the SHA512 hash in the port file needs to be changed to match the "Actual hash".

also the entry in versions/r-/rtmfp-cpp.json for version 1.3.0 still needs to be removed.

(EDIT further explanation): even though the tag v1.4.0-20230213.18168ec points to the same commit as the one you previously got a SHA512 for, the tar archive of the repo includes the tag/commit/branch name in the filenames (the top-level directory), so a different tag, even for the same commit, will have different filenames in the tar archive, so the archive file and its hash will be different.

as-shura · 2023-03-01T15:06:44Z

merge please

Added rtmfp-cpp library.

52c2c74

github-actions bot requested changes Feb 4, 2023

View reviewed changes

Fix version database.

d7f4520

github-actions bot approved these changes Feb 4, 2023

View reviewed changes

as-shura added 2 commits February 4, 2023 03:43

Added baseline.

3111c0e

Merge branch 'rtmfp-cpp' of https://github.com/as-shura/vcpkg into rt…

5d8ef98

…mfp-cpp

github-actions bot previously approved these changes Feb 4, 2023

View reviewed changes

as-shura mentioned this pull request Feb 4, 2023

Port of rtmfp-cpp to vcpkg zenomt/rtmfp-cpp#13

Closed

Fixed few things.

c6c38c1

as-shura dismissed github-actions’s stale review via c6c38c1 February 4, 2023 12:35

github-actions bot requested changes Feb 4, 2023

View reviewed changes

dg0yt suggested changes Feb 4, 2023

View reviewed changes

ports/rtmfp-cpp/portfile.cmake Outdated Show resolved Hide resolved

Cheney-W assigned Adela0814 Feb 6, 2023

Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 6, 2023

Update version database

5e91273

github-actions bot previously approved these changes Feb 10, 2023

View reviewed changes

as-shura added 2 commits February 16, 2023 13:39

Removed ref id.

e1584a6

DB update.

a8aa50b

as-shura dismissed github-actions’s stale review via a8aa50b February 16, 2023 12:40

github-actions bot previously approved these changes Feb 16, 2023

View reviewed changes

zenomt suggested changes Feb 16, 2023

View reviewed changes

ports/rtmfp-cpp/portfile.cmake Outdated Show resolved Hide resolved

Merge branch 'rtmfp-cpp' of https://github.com/as-shura/vcpkg into rt…

5c590de

…mfp-cpp

github-actions bot requested changes Feb 17, 2023

View reviewed changes

Update version database

b18d72a

github-actions bot previously approved these changes Feb 17, 2023

View reviewed changes

as-shura requested a review from Adela0814 February 17, 2023 23:14

zenomt reviewed Feb 18, 2023

View reviewed changes

zenomt suggested changes Feb 18, 2023

View reviewed changes

Small modification.

66fbc30

Adela0814 previously approved these changes Feb 23, 2023

View reviewed changes

Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 23, 2023

JavierMatosD added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Feb 23, 2023

vcpkg x-add-version --overwrite-version --all

5f26c3b

as-shura dismissed stale reviews from Adela0814 and github-actions via 5f26c3b February 25, 2023 15:40

as-shura added 4 commits February 27, 2023 15:05

New hash.

7a948df

DB update.

52f0a93

Fix license.

c25f057

DB update.

81e8755

Adela0814 approved these changes Mar 2, 2023

View reviewed changes

Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 2, 2023

dan-shaw merged commit 62fb5ef into microsoft:master Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rtmfp-cpp] Added rtmfp-cpp library #29442

[rtmfp-cpp] Added rtmfp-cpp library #29442

as-shura commented Feb 4, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

as-shura commented Feb 4, 2023

Adela0814 commented Feb 10, 2023

github-actions bot left a comment

as-shura commented Feb 10, 2023

Adela0814 commented Feb 14, 2023

as-shura commented Feb 14, 2023

as-shura commented Feb 15, 2023

zenomt commented Feb 16, 2023

as-shura commented Feb 16, 2023

github-actions bot left a comment

zenomt commented Feb 16, 2023 •

edited

github-actions bot left a comment

zenomt Feb 18, 2023

dg0yt Feb 18, 2023

zenomt Feb 18, 2023

zenomt Feb 18, 2023

zenomt commented Feb 20, 2023

dg0yt commented Feb 21, 2023

JavierMatosD commented Feb 23, 2023

as-shura commented Feb 25, 2023

zenomt commented Feb 25, 2023 •

edited

as-shura commented Mar 1, 2023

[rtmfp-cpp] Added rtmfp-cpp library #29442

[rtmfp-cpp] Added rtmfp-cpp library #29442

Conversation

as-shura commented Feb 4, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

as-shura commented Feb 4, 2023

Adela0814 commented Feb 10, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

as-shura commented Feb 10, 2023

Adela0814 commented Feb 14, 2023

as-shura commented Feb 14, 2023

as-shura commented Feb 15, 2023

zenomt commented Feb 16, 2023

as-shura commented Feb 16, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

zenomt commented Feb 16, 2023 • edited

github-actions bot left a comment

Choose a reason for hiding this comment

zenomt Feb 18, 2023

Choose a reason for hiding this comment

dg0yt Feb 18, 2023

Choose a reason for hiding this comment

zenomt Feb 18, 2023

Choose a reason for hiding this comment

zenomt Feb 18, 2023

Choose a reason for hiding this comment

zenomt commented Feb 20, 2023

dg0yt commented Feb 21, 2023

JavierMatosD commented Feb 23, 2023

as-shura commented Feb 25, 2023

zenomt commented Feb 25, 2023 • edited

as-shura commented Mar 1, 2023

zenomt commented Feb 16, 2023 •

edited

zenomt commented Feb 25, 2023 •

edited