Generalize KeyFile
to EncryptedFile
#14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a generalization of the
KeyFile
andInvalidKeyStorePath
class.Generalize
KeyFile
toEncryptedFile
The
KeyFile
can be used multifunctionally if theKeyStore
part is removed from theKeyFile
class. The key file then changes into a non-specific encrypted file.The calling party then becomes responsible for encoding and decoding the encrypted data, rather than the key file itself.
The key file contained a
baseAddress
field that was not used. Instead of resolving thebaseAddress
directly within the implementation, It now accepts a metadata argument, containing key/value pairs. This keeps the class generalized and allows the addition of awalletType
property to solve the issue of differiating between different wallet types.Encrypted files for hardware wallets store different data than keystore wallets. The keystore manager will validate the correct wallet type only if the field is present in the metadata; otherwise it assumes its a
KeyStore
.Other changes
InvalidKeyStorePath
toWalletException
KeyStoreManager
statelessEncryptedFile