Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm3 build updating uglifyjs to version 2 #80

Merged
merged 2 commits into from Oct 13, 2015
Merged

fix npm3 build updating uglifyjs to version 2 #80

merged 2 commits into from Oct 13, 2015

Conversation

heldr
Copy link
Contributor

@heldr heldr commented Oct 7, 2015

UglifyJS 1 fails on NPM 3 since it needs grunt explicitly defined as dependency.

So, following #69 stats.

UglifyJS 1

$ gzipped dist/clipboard.min.js                  
Original size: 7.67 kB
Compressed size: 2.61 kB
Compression ratio: 33.99%

UglifyJS 2 (with mangle and screw ie8 option)

$ gzipped dist/clipboard.min.js
Original size: 7.70 kB
Compressed size: 2.60 kB
Compression ratio: 33.73%

@heldr heldr changed the title fix npm3 build updating uglifyjs to 2 fix npm3 build updating uglifyjs to version 2 Oct 7, 2015
@zenorocha
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@zenorocha
Copy link
Owner

Hey @heldr, looks good!

In order to accept this, you need to remove the changes in the minified file. You can just commit the changes on the package.json and push force.

@heldr
Copy link
Contributor Author

heldr commented Oct 13, 2015

@zenorocha done! 🍵

zenorocha added a commit that referenced this pull request Oct 13, 2015
fix npm3 build updating uglifyjs to version 2
@zenorocha zenorocha merged commit 9fb666b into zenorocha:master Oct 13, 2015
@zenorocha
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants