Support NET-SNMP 5.8 #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - This field was added to the struct in NET-SNMP 5.8, causing a binary incompatibility. Reference: net-snmp/net-snmp@f629d12
Because: - This field was added to the netsnmp_session struct in NET-SNMP 5.8, causing a binary incompatibility. Reference: net-snmp/net-snmp@cd5174a
Because: - These size constants used for struct sizes were doubled in NET-SNMP 5.8, causing a binary incompatibility. Reference: net-snmp/net-snmp@09ac3f2
|
Jenkins cannot run this build automatically. Can one of the admins verify this patch? To kick off the pull verification add a comment with "ok to test". |
|
Can one of the admins verify this patch? |
The definition bbdfa5a was trying to make was for `trap_stats`, not `msgMaxSize`. Looks like this was a stupid copypasta error.
|
Has someone tested the dev version 0.41.3 and know if net-snmp 5.8 works with it ? Thanks |
Deer-WarLord
added a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NET-SNMP 5.8 made changes to the session and pdu structs. This caused binary incompatibilites with pynetsnmp's definitions of the same structs (and hence, segmentation faults in strange places).
These changes seem to be the minimum necessary to get simple usage of pynetsnmp with NET-SNMP 5.8 to work.