Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEN-16442 - Improve indexFully synchronization, add timers, add summary_event.closed_status, batch dedups by fingerprint_hash #62

Merged
merged 4 commits into from Feb 27, 2015

Conversation

kindkid
Copy link
Contributor

@kindkid kindkid commented Feb 24, 2015

  • While adding timers, the introduction of the Counters interface was necessary to break cycles going through StatisticsServiceImpl. Trying to simply add Timed annotations resulted in spring framework errors.
  • Adding summary_event.closed_status allows us to write queries and use composite indexes for much better query performance when there are lots of closed/aged/cleared events in the event_summary table.
  • When a large portion of the events map to a small handful of fingerprint_hash values (lots of deduping), zep's ability to handle events pulled from rabbitmq suffered dramatically due to the transactions becoming serialized behind a "SELECT ... FROM event_summary ... FOR UPDATE" by fingerprint_hash. Batching the incoming events by fingerprint_hash for events that (may) need deduping improves performance.

iancmcc added a commit that referenced this pull request Feb 27, 2015
ZEN-16442 - Improve indexFully synchronization, add timers, add summary_event.closed_status, batch dedups by fingerprint_hash
@iancmcc iancmcc merged commit 9cf5f11 into support/5.0.x Feb 27, 2015
@skyrych skyrych deleted the feature/ZEN-16442-5.0.x branch October 18, 2017 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants