Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album keywords taken from image keywords inside that album #4

Closed
sbillard opened this issue Oct 20, 2012 · 6 comments
Closed

Album keywords taken from image keywords inside that album #4

sbillard opened this issue Oct 20, 2012 · 6 comments
Assignees
Milestone

Comments

@sbillard
Copy link
Contributor

I activated the metatag plugin. When I view image.php, the html source shows the keywords and description of that image. But when I view the thumbs page, those keywords are not there. I know they depend on the keywords added for the album, but would it not be easier and more efficient if the keywords were taken from the images inside that album? To prevent too many keywords, the album keyword list could be limited to a specific number of most frequently present keywords inside that album.

This issue relocated from TRAC: http://www.zenphoto.org/trac/ticket/2214

@ghost ghost assigned acrylian Oct 20, 2012
@acrylian
Copy link
Member

Moved to 1.4.5 as I will not get to this for 1.4.4. There is also one issue with assigning the image tags to an album. This is also meant to be used with the tag_extras plugin that prints a tag cloud of those tags. If we assign them we will still need something to count. Isn't the benefit gone then?

@sbillard
Copy link
Contributor Author

"but would it not be easier and more efficient if the keywords were taken from the images inside that album?"

It would certainly be harder and much less efficient to do this. Keywords from an album are a simple joined query. To do the same for all the images within an album requires first a query to find the "id"s of all the images within the album, then a query to find all the keywords associated with those "id"s.

Also, would you want the tags from all the images in the album or just the ones whose thumbnails appear on the page? That would make things even harder.

Wouldn't it be simpler (and maybe easier) to just tag the albums with the keywords you want?

@acrylian
Copy link
Member

The current tags_extras plugin does collect the tags from all the images within an album (incl. subalbums).

That is useful to present visitors an overview over the contents of an album so they may directly use the tag search or whatever.

That this currently requires two queries is of course because of our inheriting rights system. Otherwise you could do it all with one query. As far as I know are plain queries not that performance hungry as MySQL is a separate server. And if the html cache is used it should not cause that much overhead, right?

So the easiest will probably be to have this collector present options to collect:

  • tags from the direct images of the album
  • tags of all images incl. those of subalbums
  • tags from subalbums.

Still this would be a thing you need to manually maintain so any tag change or subalbum/image deletion would not be reflected automatically. But that is the same for the sitemap for example.

@acrylian
Copy link
Member

Move to 2.0 as it has no priority for me.

@sbillard
Copy link
Contributor Author

sbillard commented Jan 7, 2014

I doubt this will ever get implemented. It is over a year old and seems not to have any current interest.

@sbillard sbillard closed this as completed Jan 7, 2014
@acrylian
Copy link
Member

acrylian commented Jan 7, 2014

I still have it on my list but with low priority right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants