-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: relation fields are included even if they are set false
in select clause
#1429
Conversation
WalkthroughWalkthroughThe recent updates involve enhancements in the policy utility class to optimize query processing, correction of a typo in an error message within the expression validator, and the introduction of a regression test to address a discrepancy in data querying with relation fields. These changes aim to refine functionality and ensure consistency in data handling across different components of the software. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- packages/runtime/src/enhancements/policy/policy-utils.ts (1 hunks)
- packages/schema/src/language-server/validator/expression-validator.ts (1 hunks)
- tests/regression/tests/issue-1427.test.ts (1 hunks)
Files not reviewed due to errors (1)
- packages/runtime/src/enhancements/policy/policy-utils.ts (no review received)
Files skipped from review due to trivial changes (1)
- packages/schema/src/language-server/validator/expression-validator.ts
Additional comments not posted (1)
tests/regression/tests/issue-1427.test.ts (1)
3-42
: The test case is well-structured and effectively tests the exclusion of fields set tofalse
in the select clause, as described in the PR objectives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/schema/tests/schema/validation/attribute-validation.test.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/schema/tests/schema/validation/attribute-validation.test.ts
Fixes #1427