Merge pull request #207 from kbond/fix-migrations-php8

Fix migration tests on PHP8
zenstruck · Oct 21, 2021 · 6870966 · 6870966
2 parents 2ef6c6a + 676f00a
commit 6870966
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -85,14 +85,12 @@ jobs:
 
       - name: 'Test: MySQL, DoctrineMigrationsBundle'
         run: vendor/bin/simple-phpunit -v
-        if: matrix.php < 8.0
         env:
           FOUNDRY_RESET_MODE: migrate
           DATABASE_URL: mysql://root:1234@127.0.0.1:3306/zenstruck_foundry?serverVersion=5.7
 
       - name: 'Test: MySQL, DoctrineMigrationsBundle, DAMABundle'
         run: vendor/bin/simple-phpunit -v --configuration phpunit-dama-doctrine.xml.dist
-        if: matrix.php < 8.0
         env:
           FOUNDRY_RESET_MODE: migrate
           DATABASE_URL: mysql://root:1234@127.0.0.1:3306/zenstruck_foundry?serverVersion=5.7

diff --git a/tests/Fixtures/Migrations/Version20210218175742.php b/tests/Fixtures/Migrations/Version20210218175742.php
@@ -28,4 +28,9 @@ public function up(Schema $schema): void
     public function down(Schema $schema): void
     {
     }
+
+    public function isTransactional(): bool
+    {
+        return false;
+    }
 }
diff --git a/tests/Fixtures/Migrations/Version20210318175742.php b/tests/Fixtures/Migrations/Version20210318175742.php
@@ -26,4 +26,9 @@ public function up(Schema $schema): void
     public function down(Schema $schema): void
     {
     }
+
+    public function isTransactional(): bool
+    {
+        return false;
+    }
 }
diff --git a/tests/Fixtures/Migrations/Version20210820131815.php b/tests/Fixtures/Migrations/Version20210820131815.php
@@ -38,4 +38,9 @@ public function up(Schema $schema): void
     public function down(Schema $schema): void
     {
     }
+
+    public function isTransactional(): bool
+    {
+        return false;
+    }
 }