Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #1

Merged
merged 53 commits into from
Jul 5, 2020
Merged

Refactor #1

merged 53 commits into from
Jul 5, 2020

Commits on Jun 13, 2020

  1. [BC BREAK] remove static ModelFactory methods:

    - make()
    - makeMany()
    - create()
    - createMany()
    kbond committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    3e188b5 View commit details
    Browse the repository at this point in the history
  2. [BC BREAK] rename Factory methods:

    - persist() -> create()
    - persistMany() -> createMany()
    kbond committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    0b91249 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. [BC BREAK] refactor instantiator:

    - by default, use symfony/property-access to set values and disallow extra properties
    - attribute keys can be prefixed with "optional:" to ignore
    - attribute keys can be prefixed with "force:" to "force set" their value to properties directly
    - add option to disable constructor
    - add option to always allow extra attributes
    - add option to always "force set" attributes
    kbond committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    7b5d2b5 View commit details
    Browse the repository at this point in the history
  2. [bug] refactor ModelFactory::initialize()

    - remove self return type, add return static to docblock
    - ensure instance of current factory is returned
    kbond committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    a27a1b4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e592da5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9170214 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    63f9c99 View commit details
    Browse the repository at this point in the history
  6. [minor] cs fixes

    kbond committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f1a79ba View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    24fa5d4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8201a5d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3ae9b0c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    49d94b3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    71d1d49 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    14f5bcb View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    24ea355 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Configuration menu
    Copy the full SHA
    241ce9b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1226f05 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    18036d6 View commit details
    Browse the repository at this point in the history
  4. [BC BREAK] remove Factory::instantiate() and instantiateMany() - alte…

    …rnative:
    
    - $factory->withoutPersisting()->create()->object()
    - array_map(fn($p) => $p->object(), $factory->withoutPersisting()->createMany())
    kbond committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    8f80ac1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    020d84c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    29115d8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c30982f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    80922f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Configuration menu
    Copy the full SHA
    1a8f4c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    945df0d View commit details
    Browse the repository at this point in the history
  3. [wip] refactor to require bundle:

    - make Manager constructor arguments required
    - remove Manager::boot()
    - make Manager/StoryManager services
    - call Factory::boot() in ZenstruckFoundryBundle::boot()
    kbond committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    94ae895 View commit details
    Browse the repository at this point in the history
  4. [feature] autoconfigure Story services:

    - add test to ensure stories as services are loaded correctly
    kbond committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    9bd2742 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bc84794 View commit details
    Browse the repository at this point in the history
  6. [bug] remove injecting Manager into Proxy:

    - proxies created in global state would have a different "Manager" than the
    one used in your tests causing the om to think these were not persisted.
    Always grabbing the current manager from Factory::manager() solves this.
    - also removed injecting into RepositoryProxy to be consistent.
    kbond committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    9dde476 View commit details
    Browse the repository at this point in the history
  7. [minor] rename Test/Configuration to Test/TestState:

    - using without bundle must be explicitly configured
    kbond committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    be65422 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9b036c3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    523e025 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    30ee6a9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f7a53fb View commit details
    Browse the repository at this point in the history
  12. [feature] add bundle config

    kbond committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    c85ec3e View commit details
    Browse the repository at this point in the history
  13. [bug] don't compile container

    kbond committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    01e4069 View commit details
    Browse the repository at this point in the history
  14. [minor] adjust typehint

    kbond committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    651190f View commit details
    Browse the repository at this point in the history
  15. [minor] add todos

    kbond committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    90b1709 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Configuration menu
    Copy the full SHA
    ee4c18e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    833434a View commit details
    Browse the repository at this point in the history
  3. [minor] rename Factory::instantiate() to instantiateWith()

    Makes the method a bit clearer.
    kbond committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    84919b8 View commit details
    Browse the repository at this point in the history
  4. [minor] refactor Proxy auto-refresh methods

    - rename withAutoRefresh() to enableAutoRefresh()
    - rename withoutAutoRefresh() to disableAutoRefresh()
    - add withoutAutoRefresh(callable) to disable before executing callback
    and re-enable after
    - withoutAutoRefresh's closure takes the Proxy by default, but if its
    type-hint is the wrapped object, it is passed
    kbond committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    3007559 View commit details
    Browse the repository at this point in the history
  5. [minor] split RepositoryProxy::randomSet() into randomSet/randomRange

    - also split ModelFactory::randomSet() into randomSet/randomRange
    kbond committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    3b7d753 View commit details
    Browse the repository at this point in the history
  6. [minor] default makers to generate in src/

    add --test option to generate in tests/
    kbond committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    9fb946c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    de504d7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f52111a View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. [minor] allow PHP 7.3

    kbond committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    6890d12 View commit details
    Browse the repository at this point in the history
  2. [minor] allow PHP 7.2

    kbond committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    b99482d View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Configuration menu
    Copy the full SHA
    e76b82f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1cb4b31 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    874381e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1b69f3e View commit details
    Browse the repository at this point in the history
  5. [minor] misc cleanup

    kbond committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    6a7f48a View commit details
    Browse the repository at this point in the history