Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only list entities which do not have factories #162

Merged
merged 6 commits into from May 18, 2021
Merged

Only list entities which do not have factories #162

merged 6 commits into from May 18, 2021

Conversation

jschaedl
Copy link
Contributor

Fixes #82

jschaedl
jschaedl commented May 15, 2021
View reviewed changes
src/ModelFactory.php Outdated Show resolved Hide resolved
kbond
kbond requested changes May 16, 2021
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just get the CI passing and I'll merge!

@jschaedl
Copy link
Contributor Author

jschaedl commented May 18, 2021 •
edited

I still need to fix the tests. I will try to do that tmrw.

@kbond
Copy link
Member

kbond commented May 18, 2021

I fixed the tests and added an assertion to ensure existing factory entities aren't displayed.

Thanks @jschaedl!

@kbond kbond merged commit 112d57d into zenstruck:master May 18, 2021
@jschaedl jschaedl deleted the issue-82 branch May 18, 2021 21:40
@kbond kbond mentioned this pull request May 18, 2021
Open
13 tasks
@wouterj
Copy link
Contributor

wouterj commented May 18, 2021

Wohoo, this is great. Thanks @jschaedl!

@kbond kbond mentioned this pull request May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make:factory only list entities that don't have factories already
3 participants
@jschaedl @kbond @wouterj