fix(orm): reset database instead of dropping the schema when using migrations #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the bug
On Foundry 2.x, the
resetSchemamethod callsdropSchemawhatever mode is configured. On Foundry 1.x, the same call detects themigratemode and resets the database instead of dropping the schema.I think this was made this way in case of multiple schemas in the same database (which is the case in my client project), and to prevent any undesired behaviors (e.g:
doctrine:schema:dropdoesn't seem to remove all schemas from the database in case of multiple schemas).Possible solution
Backporting some code from 1.x to detect the mode on
dropSchemaand reset the database instead fixes this bug.