-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add sf 7.1 #622
ci: add sf 7.1 #622
Conversation
5c3fd75
to
3333722
Compare
I see that autorefresh is called while the entity might not be initialized yet? |
hmmm indeed, maybe it would make sense to only call it if the object is initialized
I don't think 🤔 Not sure to see how to do that... Would that help in our problem? The property You can see here how the proxy is created. |
Something which is super strange (for me, at least 😅) is that I have plenty of deprecations which say for instance:
meaning |
Just follow my advice, the current use is not compliant with the lazy objects. Chose one way or the other but the current one is indeed broken ;) |
I understand our implementation is broken, but I don't see how to fix it 😅 how could I declare the property to be skipped, please? this sounds like the simplest solution thanks! |
Check the signature of the factory method you're calling. |
You mean
public static function createLazyProxy(\Closure $initializer, ?object $instance = null): static only public static function createLazyGhost(\Closure $initializer, ?array $skippedProperties = null, ?object $instance = null): static |
3333722
to
bf11ca7
Compare
our proxy system does not work with
symfony/var-exporter
7.1:or
I don't understand why it fails now, because everything is fine in
7.0.8
and nothing big was release since then https://github.com/symfony/var-exporter/releasesHere is how a proxy class generated with
ProxyGenerator
looks like: