fix: handle contravariance problem when proxifying class with unserialize method #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
changed the title
nikophil
force-pushed
the
fix/proxy-with-unserialize
branch
from
dadbbdf
to
3c48dd9
Compare
nikophil
force-pushed
the
fix/proxy-with-unserialize
branch
from
3c48dd9
to
14aa5f2
Compare
jdecool
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm monkey patching this in Foundry, since it is a blocker for several users.
fixes #639
see symfony/symfony#57460
We'll remove this code when the PR in Symfony will be released (it targets 6.4, so it will be enough to remove completely this code)