Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Default makers to generate in src/ #9

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Conversation

kbond
Copy link
Member

@kbond kbond commented Jun 23, 2020

  • Add --test option to generate in tests/

Questions:

  1. Should --test be interactive?
  2. Should the folders be plural (current) or singular? src/Stories or src/Story, src/Factories or src/Factory. Mostly, it seems the standard is singular (with the exception of Migrations).

@kbond kbond mentioned this pull request Jun 23, 2020
24 tasks
@weaverryan
Copy link
Contributor

Should --test be interactive?

I don't mind interactive questions. But in this case, in either direction, it could get kinda annoying once you've generated your 5th thing. When --test is NOT passed, we could print a message on top:

// pass --test if you want to generate files into your tests/ directory

Longer-term, you could envision a config option to default which one you want

Should the folders be plural (current) or singular? src/Stories or src/Story, src/Factories or src/Factory.

Probably singular??? :)

add --test option to generate in tests/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants