Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestEmail::assertHasFile() improvements #20

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

kbond
Copy link
Member

@kbond kbond commented Jan 11, 2023

Fixes #19.

When quotes are surrounding the filename, the assertion failed but shouldn't.

@kbond kbond added the bug Something isn't working label Jan 11, 2023
When quotes are surrounding the filename, the
assertion failed but shouldn't.
@kbond kbond changed the title fix: TestEmail::assertHasFile() TestEmail::assertHasFile() improvements Jan 11, 2023
@kbond kbond merged commit 6761253 into zenstruck:1.x Jan 11, 2023
@kbond kbond deleted the assert-has-file-fix branch January 11, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Managing quotes for attachment filename + optional blob checking
1 participant