Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always collect messages in TestTransport::$queue #62

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Feb 24, 2023

fixes #61

@kbond
Copy link
Member

kbond commented Feb 24, 2023

Hoping @gndk can verify this fix before merging.

@nikophil
Copy link
Member Author

That's what I was thinking 😇

@gndk
Copy link

gndk commented Feb 24, 2023

@nikophil @kbond Everything green, works perfectly with this fix! 👍 Thanks!

@kbond kbond merged commit 2e51d27 into zenstruck:1.x Feb 24, 2023
@kbond
Copy link
Member

kbond commented Feb 24, 2023

Great, thanks for confirming! Released 1.7.2

TristanPouliquen pushed a commit to assoconnect/messenger-test that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1.6.0 breaks most of my tests
3 participants