Implement Symfony\Contracts\Service\ResetInterface in the TestTransport

[sidz]

Implement Symfony\Contracts\Service\ResetInterface so TestTransport could be cleared automatically after each tearDown

Discussed in: #77 (comment)

[sidz]

Hey @kbond, @nikophil,.

I've raised this pull request in order to speedup improvement discussed in #77 (comment). But it seems like there are a couple of test cases which have been written to be sure that state is persisting between tests.

messenger-test/tests/InteractsWithMessengerTest.php

Lines 522 to 536 in 7164fce

	public function transport_data_is_persisted_between_requests_and_kernel_shutdown(): void
	{
	self::bootKernel();
	self::getContainer()->get(MessageBusInterface::class)->dispatch(new MessageA());
	self::getContainer()->get(MessageBusInterface::class)->dispatch(new MessageA(true));
	$this->transport()->queue()->assertCount(2);
	self::ensureKernelShutdown();
	self::bootKernel();
	$this->transport()->queue()->assertCount(2);
	$this->transport()->process();

messenger-test/tests/InteractsWithMessengerTest.php

Lines 584 to 602 in 7164fce

	public function disabling_intercept_is_remembered_between_kernel_reboots(): void
	{
	self::bootKernel();
	$this->transport()->unblock();
	self::getContainer()->get(MessageBusInterface::class)->dispatch(new MessageA());
	$this->transport()->queue()->assertEmpty();
	$this->transport()->dispatched()->assertCount(1);
	self::ensureKernelShutdown();
	self::bootKernel();
	self::getContainer()->get(MessageBusInterface::class)->dispatch(new MessageA());
	$this->transport()->queue()->assertEmpty();
	$this->transport()->dispatched()->assertCount(2);
	}

so my PR seems like a BC break.

[kbond]

But it seems like there are a couple of test cases which have been written to be sure that state is persisting between tests.

Not between tests but between kernel reboots within a single test. We need to keep this behaviour.

I think the crux of the issue is in tests NOT using InteractsWithMessenger, we do want the transport reset on reboot.

[nikophil]

hi @sidz

we should detect if the current test uses the trait InteractWithMessenger (maybe by doing something similar than here)

And if we detect that the trait was used, we should do nothing in reset()

but it makes me think that this is also a BC break, because TestTransport::reset() is a public method, which is documented... we should not change its behavior this way.... WDYT @kbond?