Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate CompanionAds#xmlElement #68

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Populate CompanionAds#xmlElement #68

merged 3 commits into from
Feb 25, 2021

Conversation

timdp
Copy link
Member

@timdp timdp commented Feb 24, 2021

@coveralls
Copy link

coveralls commented Feb 24, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 95.238% when pulling f43ff6a on companion-ads-xml into b1aa22a on master.

tmdbckr
tmdbckr approved these changes Feb 24, 2021
View reviewed changes
Copy link

@tmdbckr tmdbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, although it's hard to review with the test ordering changes. I do see the companionAd both parsed and original XML, so that works fine!

@MerlierR MerlierR merged commit e90d467 into master Feb 25, 2021
@MerlierR MerlierR deleted the companion-ads-xml branch February 25, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmdbckr tmdbckr tmdbckr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timdp @coveralls @tmdbckr @MerlierR