getTemplate and listTemplates functions fixed #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorshp
requested review from
carloshenriqueds,
hmagarotto,
rodrigokamada,
wmangelardo,
rafael-org,
rafaelgpimenta and
Marcelovqvd
rafael-org
reviewed
Aug 19, 2021
|
Faltou também atualizar a versão no package.json |
rafael-org
reviewed
Aug 24, 2021
rafael-org
reviewed
Aug 31, 2021
victorshp
deleted the
con-318-corrigir-implementacao-de-get-e-list-templates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link => https://zenvia.atlassian.net/browse/CON-318?atlOrigin=eyJpIjoiNDhmNWNlMGI4OWRiNDViNzg5NGM1NGYyODQ5ZTRiZTEiLCJwIjoiaiJ9
Problem
getTemplate()andlistTemplate()functions were non-functional.This hindered this SDK's user to list all their templates or a single template associated with a specific token registered on their Zenvia account.
Diagnostics
The
.forEach()functions in line 162 and 180 (before pull request) were iterating over a supposed array identified by the keychannelsinside the response from GET requests ontemplates/andtemplates/:templateId.It is possible that at some point in time the
channelskey and its respective values were contained in the response for this request. If so, no longer.Implementation
To correct the problem, the request for
getTemplate()andlistTemplate()will now come as they should: unedited after they are received from the Zenvia API, but typed correctly.The tests were also fixed accordingly.