Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed-transition.lua: Suggestion for youtube generated subtitles (minimum subtitle length forced skip) #28

Closed
Reinbowsaur opened this issue Mar 24, 2021 · 4 comments

Comments

@Reinbowsaur
Copy link

Reinbowsaur commented Mar 24, 2021

Youtube generates subtitles but they are useless with this plugin unfortunately to the way they are generated, each line of subtitle will be shown until the next line is generated leaving no gaps for this plugin to skip through.

This could be solved by implementing an option that will fast foward automatically after a subtitle has being showing for a certain amount of seconds.

An option for example might be useful to call it "forcedLookAhead = x" (After a subtitle has being showing for x seconds it will forcefully speed up to the next subtitle) this is because with youtube the talker has likely already finished, while the subtitles generated by youtube will continue to show forever until it generates more subtitles, leaving massive gaps of silence, that could be skipped if detected showing too long.

@chapmanjacobd
Copy link

chapmanjacobd commented Sep 15, 2022

Yes. I have encountered subtitles from many sources (not just YouTube ones) that have this issue. A max_duration or subtitle_timeout setting should fix this.

Maybe directskip can do this or maybe similar functionality of directskip should be added to speedup mode

@chapmanjacobd
Copy link

chapmanjacobd commented Nov 17, 2022

I added this functionality to the Ben Kerman sub-skip script https://github.com/chapmanjacobd/computer/blob/main/.config/mpv/scripts/sub-skip.lua

it feels a bit hacky but it is working for me :)

@chapmanjacobd
Copy link

There were quite a few bugs but I've ironed them out:

https://github.com/chapmanjacobd/computer/blob/main/.config/mpv/scripts/sub-skip.lua

@zenyd
Copy link
Owner

zenyd commented Feb 12, 2024

This is implemented as of 9bdce00

@zenyd zenyd closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants