key bind for list of delete marks

[bitingsock]

#14

[bitingsock]

Also, if I can get permissions I'd like to help clear the issue tracker.

[zenyd]

How does this look if the file list to be deleted is so long that it wouldn't fit in the window? Maybe delimiting by ';' instead of newlines might be better plus printing also to console.

[bitingsock]

good point. take a look

[zenyd]

it doesn't get wrapped to a new line when it's too long. Doesn't matter if vertical or horizontal.
Not much we can do. One can still view the whole list on the terminal.

For osd maybe output in blocks of two or three:

<file1>; <file2>; <file3>;
<file4>; <file5>; <file6>;
....

[bitingsock]

It wraps for me:

maybe you have a sub-ass-override somewhere?

[zenyd]

indeed I had sub-ass-override=force but even with that disabled it didn't wrap for me. Maybe it's ome other sub-* option?
I tried your changes with image files. Maybe it doesn't work there? Can you please check?

[bitingsock]

[bitingsock]

I even tried it with no-config to make sure. still works

[bitingsock]

couple other changes

[bitingsock]

see if you have any osd-* in you config that might be different

[zenyd]

I tried with --no-config as well, but still the same. Anyway not so important.
Do you want me to merge?

[bitingsock]

I'd like to at least figure the source of the problem even if we can't fix it. I'm on Win10 using Shinchiro's build. What are you using?

[zenyd]

I'm also using Win10 + Shinchiro's build. My build is a little dated though.
0.33.0-67-g8121d958ec
built on Sun Jan 31

[bitingsock]

Just tried that build. Works for me. That's pretty strange. Go ahead and merge, I guess.

[zenyd]

Could you document the new keybinds in the readme? With that done I can merge.

[zenyd]

found the issue why it doesn't wrap for me. It wrapped for you because you had spaces in your filenames. When you don't have spaces it doesnt break the line. I only tested with files that had no space. Adding a space after the semicolon fixed it for me.

Then again if the filename is too long, it get's clipped on the window border still and this we can't change I think.

[bitingsock]

Oh duh. I could fix some edge cases there like converting "." into spaces.

[bitingsock]

but there should probably be a space after semicolon anyway

[zenyd]

one other thing I noticed.

When viewing the osd it still shows part of the path test/testfile.png;
On the terminal it show like this: [delete_file] deleting: C:\<...>\Desktop\test/testfile.png notice the /.

[bitingsock]

Ya I should do that differently. One sec

[bitingsock]

K try that out

[zenyd]

works fine. Merging.