Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.1.1 doesn't work with react-native #2

Closed
doomsower opened this issue Sep 5, 2017 · 3 comments
Closed

v1.1.1 doesn't work with react-native #2

doomsower opened this issue Sep 5, 2017 · 3 comments

Comments

@doomsower
Copy link
Contributor

I upgraded from v1.0.2 to v1.1.1 and react-native v0.46.4 app failed with red screen and error message React is not defined. Downgraded to v1.0.2 and everything is working again. So I guess something is wrong with rollup build?
@zenyr
Copy link
Owner

zenyr commented Sep 5, 2017

It is totally possible that I had mis-configured package.json. I'll tinker with that but in the meantime you can stay on 1.0.2 since it should be exactly same anyway. Only documentations and stuff was updated.

Thanks for the report!

zenyr added a commit that referenced this issue Sep 5, 2017
@zenyr
fix import in react-native
130620f 
fixes issue #2
@zenyr
Copy link
Owner

zenyr commented Sep 5, 2017

v1.1.3 should fix the issue now. TBH it is only tested on my setup so let me know if this fix was not enough for you. 😸

@doomsower
Copy link
Contributor Author

Thank you, it works now!

@zenyr zenyr closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zenyr @doomsower