#1259 - Add failing test case

zephir-lang · Apr 19, 2021 · 7779437 · 7779437
1 parent 5433438
commit 7779437
Show file tree

Hide file tree

Showing 5 changed files with 150 additions and 1 deletion.
diff --git a/ext/stub/arrayaccesstest.zep.c b/ext/stub/arrayaccesstest.zep.c
diff --git a/ext/stub/arrayaccesstest.zep.h b/ext/stub/arrayaccesstest.zep.h
diff --git a/ext/stub/properties/staticprotectedproperties.zep.c b/ext/stub/properties/staticprotectedproperties.zep.c
diff --git a/stub/arrayaccesstest.zep b/stub/arrayaccesstest.zep
@@ -3,6 +3,7 @@ namespace Stub;
 class ArrayAccessTest
 {
     protected data;
+    protected unsetData = ["key_a": "marcin", "key_b": "paula"];
 
 	public static function exits()
 	{
@@ -117,4 +118,33 @@ class ArrayAccessTest
 
         return params;
     }
+
+    /**
+     * @issue https://github.com/zephir-lang/zephir/issues/1259
+     */
+    public function issue1259UnsetKeyFromArrayInternalVariable() -> array
+    {
+        array ret = [];
+        array unsetData = ["key_a": "marcin", "key_b": "paula"];
+
+        let ret[] = unsetData;
+        unset(unsetData["key_a"]);
+        let ret[] = unsetData;
+
+        return ret;
+    }
+
+    /**
+     * @issue https://github.com/zephir-lang/zephir/issues/1259
+     */
+    public function issue1259UnsetKeyFromArrayProperty() -> array
+    {
+        array ret = [];
+
+        let ret[] = this->unsetData;
+        unset(this->unsetData["key_a"]);
+        let ret[] = this->unsetData;
+
+        return ret;
+    }
 }
diff --git a/tests/Extension/ArrayAccessTest.php b/tests/Extension/ArrayAccessTest.php
@@ -75,4 +75,20 @@ public function testIssue1086StaticallyCalledFunctionWithArrayAsArgMustReturnArr
         $actual = $class->issue1086WontNullArrayAfterPassViaStaticWithoutStrictParams();
         $this->assertSame(['test' => 123], $actual);
     }
+
+    /**
+     * @issue https://github.com/zephir-lang/zephir/issues/1259
+     */
+    public function testIssue1259CheckUnsetKeyFromArray(): void
+    {
+        $class = new \Stub\ArrayAccessTest();
+
+        $expected = [
+            ['key_a' => 'marcin', 'key_b' => 'paula'],
+            ['key_b' => 'paula'],
+        ];
+
+        $this->assertSame($expected, $class->issue1259UnsetKeyFromArrayInternalVariable());
+        $this->assertSame($expected, $class->issue1259UnsetKeyFromArrayProperty());
+    }
 }