#2280 - Implement support for string type in php.ini

zephir-lang · Oct 5, 2021 · 8694ed2 · 8694ed2
1 parent 093afda
commit 8694ed2
Show file tree

Hide file tree

Showing 12 changed files with 134 additions and 48 deletions.
diff --git a/Library/Backends/ZendEngine2/Backend.php b/Library/Backends/ZendEngine2/Backend.php
@@ -1102,12 +1102,12 @@ protected function assignHelper(
         return $output;
     }
 
-    protected function returnHelper($macro, $value, CompilationContext $context, $useCodePrinter, $doCopy = null)
+    protected function returnHelper(string $macro, $value, CompilationContext $context, $useCodePrinter, $doCopy = null): string
     {
         if ($value instanceof Variable) {
             $value = $value->getName();
-        } else {
-            $value = 'RETURN_MM_STRING' == $macro ? '"'.$value.'"' : $value;
+        } elseif ($macro === 'RETURN_MM_STRING' && !preg_match('/^ZEPHIR_GLOBAL/', $value)) {
+            $value = '"'.$value.'"';
         }
 
         $copyStr = '';

diff --git a/Library/Backends/ZendEngine3/Backend.php b/Library/Backends/ZendEngine3/Backend.php
@@ -575,7 +575,7 @@ public function assignZval(Variable $variable, $code, CompilationContext $contex
 
     public function returnString($value, CompilationContext $context, $useCodePrinter = true, $doCopy = true)
     {
-        return $this->returnHelper('RETURN_MM_STRING', $value, $context, $useCodePrinter, null);
+        return $this->returnHelper('RETURN_MM_STRING', $value, $context, $useCodePrinter);
     }
 
     public function createClosure(Variable $variable, $classDefinition, CompilationContext $context)

diff --git a/Library/Compiler.php b/Library/Compiler.php
@@ -1325,7 +1325,7 @@ public function processExtensionGlobals(string $namespace): array
                     $structBuilder->addProperty($field, $global);
 
                     $isModuleGlobal = (int) !empty($global['module']);
-                    $globalsDefault[$isModuleGlobal][] = $structBuilder->getCDefault($field, $global, $namespace).PHP_EOL;
+                    $globalsDefault[$isModuleGlobal][] = $structBuilder->getCDefault($field, $global, $namespace);
                     $initEntries[] = $structBuilder->getInitEntry($field, $global, $namespace);
                 }
 
@@ -1334,8 +1334,7 @@ public function processExtensionGlobals(string $namespace): array
 
             $globalCode = PHP_EOL;
             foreach ($structures as $structureName => $internalStructure) {
-                $globalCode .= "\t".'zephir_struct_'.$structureName.' '.
-                                $structureName.';'.PHP_EOL.PHP_EOL;
+                $globalCode .= "\t".'zephir_struct_'.$structureName.' '.$structureName.';'.PHP_EOL;
             }
 
             /**
@@ -1352,41 +1351,41 @@ public function processExtensionGlobals(string $namespace): array
 
                 $isModuleGlobal = (int) !empty($global['module']);
                 $type = $global['type'];
-                // TODO: Add support for 'string', 'hash'
+                // TODO: Add support for 'hash'
                 // TODO: Zephir\Optimizers\FunctionCall\GlobalsSetOptimizer
                 switch ($global['type']) {
                     case 'boolean':
                     case 'bool':
                         $type = 'zend_bool';
                         if (true === $global['default']) {
-                            $globalsDefault[$isModuleGlobal][] = "\t".$namespace.'_globals->'.$name.' = 1;'.PHP_EOL;
+                            $globalsDefault[$isModuleGlobal][] = "\t".$namespace.'_globals->'.$name.' = 1;';
                         } else {
-                            $globalsDefault[$isModuleGlobal][] = "\t".$namespace.'_globals->'.$name.' = 0;'.PHP_EOL;
+                            $globalsDefault[$isModuleGlobal][] = "\t".$namespace.'_globals->'.$name.' = 0;';
                         }
                         break;
 
                     case 'int':
                     case 'uint':
                     case 'long':
                     case 'double':
-                        $globalsDefault[$isModuleGlobal][]
-                            = "\t".$namespace.'_globals->'.$name.' = '.
-                            $global['default'].';'.PHP_EOL;
+                        $globalsDefault[$isModuleGlobal][] = "\t".$namespace.'_globals->'.$name.' = '.$global['default'].';';
                         break;
 
                     case 'char':
                     case 'uchar':
-                        $globalsDefault[$isModuleGlobal][]
-                            = "\t".$namespace.'_globals->'.$name.' = \''.
-                            $global['default'].'\';'.PHP_EOL;
+                        $globalsDefault[$isModuleGlobal][] = "\t".$namespace.'_globals->'.$name.' = \''.$global['default'].'\';';
+                        break;
+                    case 'string':
+                        $type = 'char *';
+                        $globalsDefault[$isModuleGlobal][] = "\t".$namespace.'_globals->'.$name.' = ZSTR_VAL(zend_string_init(ZEND_STRL("'.$global['default'].'"), 0));';
                         break;
                     default:
                         throw new Exception(
                             "Unknown type '".$global['type']."' for extension global '".$name."'"
                         );
                 }
 
-                $globalCode .= "\t".$type.' '.$name.';'.PHP_EOL.PHP_EOL;
+                $globalCode .= "\t".$type.' '.$name.';'.PHP_EOL;
                 $iniEntry = [];
                 if (isset($global['ini-entry'])) {
                     $iniEntry = $global['ini-entry'];
@@ -1425,8 +1424,8 @@ public function processExtensionGlobals(string $namespace): array
             }
         }
 
-        $globalsDefault[0] = implode('', $globalsDefault[0]);
-        $globalsDefault[1] = implode('', $globalsDefault[1]);
+        $globalsDefault[0] = implode(PHP_EOL, $globalsDefault[0]);
+        $globalsDefault[1] = implode(PHP_EOL, $globalsDefault[1]);
 
         return [$globalCode, $globalStruct, $globalsDefault, $initEntries];
     }

diff --git a/Library/Optimizers/FunctionCall/GlobalsGetOptimizer.php b/Library/Optimizers/FunctionCall/GlobalsGetOptimizer.php
@@ -9,6 +9,8 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
 namespace Zephir\Optimizers\FunctionCall;
 
 use Zephir\Call;
@@ -17,8 +19,10 @@
 use Zephir\Exception\CompilerException;
 use Zephir\Optimizers\OptimizerAbstract;
 
+use function count;
+
 /**
- * GlobalsGetOptimizer.
+ * `globals_get()` internal function.
  *
  * Reads values from extensions globals
  */
@@ -29,21 +33,20 @@ class GlobalsGetOptimizer extends OptimizerAbstract
      * @param Call               $call
      * @param CompilationContext $context
      *
+     * @return CompiledExpression|null
      * @throws CompilerException
-     *
-     * @return bool|CompiledExpression|mixed
      */
-    public function optimize(array $expression, Call $call, CompilationContext $context)
+    public function optimize(array $expression, Call $call, CompilationContext $context): ?CompiledExpression
     {
         if (!isset($expression['parameters'])) {
-            return false;
+            return null;
         }
 
-        if (1 != \count($expression['parameters'])) {
+        if (1 !== count($expression['parameters'])) {
             throw new CompilerException("'globals_get' only accepts one parameter", $expression);
         }
 
-        if ('string' != $expression['parameters'][0]['parameter']['type']) {
+        if ('string' !== $expression['parameters'][0]['parameter']['type']) {
             throw new CompilerException("A string parameter is required for 'globals_get'", $expression);
         }
 
@@ -53,14 +56,14 @@ public function optimize(array $expression, Call $call, CompilationContext $cont
             throw new CompilerException("Global '".$globalName."' cannot be read because it isn't defined", $expression);
         }
 
-        $globalDefinition = $context->compiler->getExtensionGlobal($globalName);
+        $type = $context->compiler->getExtensionGlobal($globalName)['type'];
 
         if (false !== strpos($globalName, '.')) {
             $parts = explode('.', $globalName);
 
-            return new CompiledExpression($globalDefinition['type'], 'ZEPHIR_GLOBAL('.$parts[0].').'.$parts[1], $expression);
+            return new CompiledExpression($type, 'ZEPHIR_GLOBAL('.$parts[0].').'.$parts[1], $expression);
         }
 
-        return new CompiledExpression($globalDefinition['type'], 'ZEPHIR_GLOBAL('.$globalName.')', $expression);
+        return new CompiledExpression($type, 'ZEPHIR_GLOBAL('.$globalName.')', $expression);
     }
 }
diff --git a/Library/Optimizers/FunctionCall/GlobalsSetOptimizer.php b/Library/Optimizers/FunctionCall/GlobalsSetOptimizer.php
@@ -9,6 +9,8 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
 namespace Zephir\Optimizers\FunctionCall;
 
 use Zephir\Call;
@@ -18,10 +20,12 @@
 use Zephir\Exception\CompilerException;
 use Zephir\Optimizers\OptimizerAbstract;
 
+use function count;
+
 /**
- * Zephir\Optimizers\FunctionCall\GlobalsSetOptimizer.
+ * `globals_set()` internal function.
  *
- * Writes values from extensions globals
+ * Writes values from extensions globals.
  */
 class GlobalsSetOptimizer extends OptimizerAbstract
 {
@@ -34,17 +38,17 @@ class GlobalsSetOptimizer extends OptimizerAbstract
      *
      * @return CompiledExpression
      */
-    public function optimize(array $expression, Call $call, CompilationContext $context)
+    public function optimize(array $expression, Call $call, CompilationContext $context): CompiledExpression
     {
         if (!isset($expression['parameters'])) {
             throw new CompilerException("'globals_set' requires two parameters", $expression);
         }
 
-        if (2 != \count($expression['parameters'])) {
+        if (2 !== count($expression['parameters'])) {
             throw new CompilerException("'globals_set' only accepts two parameters", $expression);
         }
 
-        if ('string' != $expression['parameters'][0]['parameter']['type']) {
+        if ('string' !== $expression['parameters'][0]['parameter']['type']) {
             throw new CompilerException("A string parameter is required for 'globals_set'", $expression);
         }
 
@@ -88,7 +92,7 @@ public function optimize(array $expression, Call $call, CompilationContext $cont
         }
     }
 
-    private function resolveInternalAccessor($globalName)
+    private function resolveInternalAccessor(string $globalName): string
     {
         $parts = explode('.', $globalName);
 
@@ -124,7 +128,7 @@ private function resolveInternalValue(array $definition, array $expression, stri
             case 'ulong':
                 return strtr('zval_get_long(:v)', [':v' => $value]);
             case 'string':
-                return strtr('zval_get_string(:v)', [':v' => $value]);
+                return strtr('ZSTR_VAL(zval_get_string(:v))', [':v' => $value]);
             case 'char':
             case 'uchar':
                 return strtr(

diff --git a/config.json b/config.json
@@ -95,6 +95,10 @@
       "type": "char",
       "default": "A"
     },
+    "my_setting_5": {
+      "type": "string",
+      "default": "custom_value"
+    },
     "db.my_setting_1": {
       "type": "bool",
       "default": false

diff --git a/ext/php_stub.h b/ext/php_stub.h
@@ -51,21 +51,14 @@ ZEND_BEGIN_MODULE_GLOBALS(stub)
 
 
 	zephir_struct_db db;
-
 	zephir_struct_orm orm;
-
 	zephir_struct_extension extension;
-
 	zend_bool my_setting_1;
-
 	zend_bool test_setting_1;
-
 	int my_setting_2;
-
 	double my_setting_3;
-
 	char my_setting_4;
-
+	char * my_setting_5;
 
 ZEND_END_MODULE_GLOBALS(stub)
 

diff --git a/ext/stub.c b/ext/stub.c
@@ -524,7 +524,7 @@ static void php_zephir_init_globals(zend_stub_globals *stub_globals)
 	stub_globals->my_setting_2 = 10;
 	stub_globals->my_setting_3 = 15.2;
 	stub_globals->my_setting_4 = 'A';
-
+	stub_globals->my_setting_5 = ZSTR_VAL(zend_string_init(ZEND_STRL("custom_value"), 0));
 
 }
 

diff --git a/ext/stub/globals.zep.c b/ext/stub/globals.zep.c