#2370 - Remove zephir_mt_rand() and its optimizer

Since PHP8.2 there were changes and optimizations in random extension.
zephir-lang · Sep 19, 2022 · cc3a742 · cc3a742
1 parent 42528b0
commit cc3a742
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 68 deletions.
diff --git a/Library/Optimizers/FunctionCall/MtRandOptimizer.php b/Library/Optimizers/FunctionCall/MtRandOptimizer.php
diff --git a/kernels/ZendEngine3/math.c b/kernels/ZendEngine3/math.c
@@ -181,20 +181,6 @@ void zephir_round(zval *return_value, zval *op1, zval *op2, zval *op3)
 	}
 }
 
-zend_long zephir_mt_rand(zend_long min, zend_long max)
-{
-	if (max < min) {
-		php_error_docref(NULL, E_WARNING, "max(" ZEND_LONG_FMT ") is smaller than min(" ZEND_LONG_FMT ")", max, min);
-		return 0;
-	}
-
-	if (!BG(mt_rand_is_seeded)) {
-		php_mt_srand(GENERATE_SEED());
-	}
-
-	return php_mt_rand_range(min, max);
-}
-
 double zephir_ldexp(zval *value, zval *expval)
 {
 	int exp = (int) zephir_get_numberval(expval);

diff --git a/kernels/ZendEngine3/math.h b/kernels/ZendEngine3/math.h
@@ -23,7 +23,6 @@ double zephir_acos(zval *op1);
 double zephir_sqrt(zval *op1);
 
 double zephir_floor(zval *op1);
-zend_long zephir_mt_rand(zend_long min, zend_long max);
 double zephir_ceil(zval *op1);
 void zephir_round(zval *return_value, zval *op1, zval *op2, zval *op3);