Segmentation Fault: Manipulating an undefined variable as an array

[CameronHall]

When running PHP as CLI $_SESSION is undefined. So attempting to call this function will attempt to append an array element to an undefined variable which results in a segmentation fault.

function set(string index, var value)
{
    var uniqueId;

    let uniqueId = this->_uniqueId;
    if !empty uniqueId {
        let _SESSION[uniqueId . "#" . index] = value;
        return;
    }

    let _SESSION[index] = value;
}

set("test"); // segfault

Thanks :)

[sergeyklay]

@dreamsxin In fact, this is an annoying problem with superglobals. It seems I have already solved this issue once. But as we can see - not. Maybe you will be able to see what I didn't see.

[dreamsxin]

@sergeyklay How did you solve it?

Option one, change zephir_array_update_* check it is null, and throw a warning.
Option two, use copy:

zval _SESSION;

zephir_get_global(&_SESSION, SL("_SESSION"));

int zephir_get_global(zval **arr, const char *global, unsigned int global_length)
{
	zval *gv;
	zend_bool jit_initialization = PG(auto_globals_jit);
	zend_string *str = zend_string_init(global, global_length, 0);

	if (jit_initialization) {
		zend_is_auto_global(str);
	}

	if (&EG(symbol_table)) {
		if ((gv = zend_hash_find_ind(&EG(symbol_table), str)) != NULL) {
			ZVAL_DEREF(gv);
			if (Z_TYPE_P(gv) == IS_ARRAY) {
				ZVAL_COPY(*arr, gv);
				zend_string_release(str);
				return SUCCESS;
			}
		}
	}

	array_init(*arr);

	zend_string_release(str);
	return FAILURE;
}