Updated static property add/sub #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2038 +/- ##
=================================================
+ Coverage 35.35% 35.44% +0.08%
+ Complexity 8323 8301 -22
=================================================
Files 564 564
Lines 45744 45692 -52
=================================================
+ Hits 16175 16195 +20
+ Misses 29569 29497 -72 |
sergeyklay
reviewed
Jan 1, 2020
| { | ||
| let self::someAdd += 1.0; | ||
| let self::someSub -= 1.0; | ||
| } |
There was a problem hiding this comment.
@dreamsxin Could you create a PHPUnit test to prove these methods?
|
@sergeyklay Check again |
sergeyklay
approved these changes
Jan 2, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Thanks