Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Class Entry detection approach #2213

Closed
Jeckerson opened this issue Apr 13, 2021 · 0 comments
Closed

Review Class Entry detection approach #2213

Jeckerson opened this issue Apr 13, 2021 · 0 comments
Assignees
@Jeckerson @AlexNDRmac
Labels
enhancement
Milestone
0.14.0

Comments

@Jeckerson
Copy link
Member

Try to implement CE detection during runtime, which might give the possibility of easier compilation process...

Check if it possible to integrate zend_lookup_class:
https://github.com/php/php-src/blob/6ab4286f2ecf2c35ee97b15478cd5beb8ce6e5b2/Zend/zend_execute_API.c#L1050
@Jeckerson Jeckerson added this to the 0.14.x milestone Apr 13, 2021
@Jeckerson Jeckerson mentioned this issue Apr 22, 2021
Closed
Jeckerson added a commit that referenced this issue Jun 27, 2021
@Jeckerson
#2213 - First attempt to detect all class entries dynamically
58be1e3
Jeckerson added a commit that referenced this issue Jul 12, 2021
@Jeckerson
#2213 - Cleanup in getClassEntryByClassName() method
c2067be
Jeckerson added a commit that referenced this issue Jul 12, 2021
@Jeckerson
#2213 - Mark ClassDefinition:getClassEntryByClassName() method as dep…
6f79899 
…recated
Jeckerson added a commit that referenced this issue Jul 12, 2021
@Jeckerson
#2213 - Move class entry detection into own class Entry
955b097
Jeckerson added a commit that referenced this issue Jul 12, 2021
@Jeckerson
#2213 - Add NAMESPACE_SEPARATOR class constant
6729bd6
Jeckerson added a commit that referenced this issue Jul 12, 2021
@Jeckerson
#2213 - Fix code style
ec183ba
Jeckerson added a commit that referenced this issue Jul 18, 2021
@Jeckerson
#2213 - Optimize imports
b12ec55
Jeckerson added a commit that referenced this issue Jul 18, 2021
@Jeckerson
#2213 - Update properties types in CompilationContext class
aa852b8
Jeckerson added a commit that referenced this issue Jul 18, 2021
@Jeckerson
#2213 - Fix typo
1b4aede
Jeckerson added a commit that referenced this issue Jul 18, 2021
@Jeckerson
#2213 - Refactor Entry class
e2ba648
Jeckerson added a commit that referenced this issue Jul 18, 2021
@Jeckerson
#2213 - Apply new class entry detection approach
7e375dc 
(where it currently possible)
Jeckerson added a commit that referenced this issue Jul 19, 2021
@Jeckerson
#2213 - Change usage of zend_string_init_fast to zend_string_init
49078ca
Jeckerson added a commit that referenced this issue Jul 19, 2021
@Jeckerson
#2213 - Optimize imports
a04cec5
Jeckerson added a commit that referenced this issue Jul 19, 2021
@Jeckerson
#2213 - Fix class name passer
ba9d42a
@Jeckerson Jeckerson mentioned this issue Jul 25, 2021
Closed
Jeckerson added a commit that referenced this issue Aug 5, 2021
@Jeckerson
#2213 - Partial regenerate of ext/ directory
d55d2f1
Jeckerson added a commit that referenced this issue Aug 5, 2021
@Jeckerson
#2213 - Partial regenerate of ext/ directory
5eb4ee8
Jeckerson added a commit that referenced this issue Aug 5, 2021
@Jeckerson
#2213 - Remove deprecated method getClassEntryByClassName()
bc52dc0
Jeckerson added a commit that referenced this issue Aug 5, 2021
@Jeckerson
#2213 - Move repetitive headers paths to class constants
e7a044b
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Fix code style
efc507e
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Remove unused method processExpectedComplexLiteralReturn()
5052933
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Fix class name definition
fed76d8
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Minor code refactor
7b89aee
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Move class entries array into separate config file
d2eb577
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Fix argument type in ClassConstant constructor
08fb6a6
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Fix return type of getDocBlock() method
a9ce20f
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Fix require
6fe55d9
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Update CHANGELOG.md
6084cf2
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Mass types refactor
0862419
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
#2213 - Mass types refactor
69fcba5
Jeckerson added a commit that referenced this issue Aug 6, 2021
@Jeckerson
Merge pull request #2251 from zephir-lang/#2213-ce-detection
e4bf12f 
#2213 - Dynamic Class Entry detection
@Jeckerson Jeckerson mentioned this issue Sep 7, 2021
Closed
@Jeckerson Jeckerson modified the milestones: 0.14.x, 0.14.0 Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

@AlexNDRmac AlexNDRmac

Labels
enhancement
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
2 participants
@Jeckerson @AlexNDRmac