New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to configure their phpize and php-config location from their projects #1175
Conversation
I think zephir generate --parser-compiled=force |
* @param FunctionDefinition $func | ||
* @param array $statement | ||
* @param null $statement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am used to see what's the default parameter, but if you agree i will change it back to array
i saw the Easy to remove if you want. |
I do not quite see a point for adding a configuration for phpize/php-config. The alwaysCompileParser stuff is unnecessary: A proper parser detection |
the point is that my ubuntu comes with php 5.3 and no updates. |
It doesn't make sense to configure the path to PHP in a configuration which is specific to zephir, If you want to use a custom path to php-config/phpize that's something to be configured by modifying your path (as zephir doesn't support environmental variables for this kind of stuff). |
i am not gonna argue, but i am pretty sure people will start crying over this. Many people are compiling their php's. I am pretty sure i am not the only one, now i am force to edit my Thank you for the feedback. |
Again this isn't a problem at all. It could make sense though to allow users to specify something like |
allow users to add those options into their project/config.json file
the reason i added
alwaysCompileParser
is because i saw couple of issues about people trying php 7, then they go back to php5 and in this case compiling the parser throws errors. Enabling this should prevent any kind of errors of this kind.also removed the
@unlink
stuff since i hate it :D