Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix | #1604 | Duplicate extension key prefix #1809

Merged
merged 9 commits into from
Feb 19, 2019

Conversation

AlexNDRmac
Copy link
Member

@AlexNDRmac AlexNDRmac commented Feb 18, 2019

Refs: #1604

@AlexNDRmac
Copy link
Member Author

AlexNDRmac commented Feb 18, 2019

cc @dreamsxin Now you can see what I meant when told about fix in Library/Compiler.php
There is Test with Expected result, so we can use it as target point.
Travis failed buld: https://travis-ci.org/phalcon/zephir/jobs/495101242

@dreamsxin
Copy link
Contributor

This config

    "globals": {
        "test.my_setting_1": {
            "type": "bool",
            "default": false
        },
    },

change to:

    "globals": {
        "my_setting_1": {
            "type": "bool",
            "default": false
        },
    },

will generate test.my_setting_1.

Library/Code/Builder/Struct.php Outdated Show resolved Hide resolved
Library/Code/Builder/Struct.php Outdated Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
ext/php_test.h Outdated Show resolved Hide resolved
ext/php_test.h Outdated Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #1809 into development will increase coverage by 0.06%.
The diff coverage is 65.48%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1809      +/-   ##
=================================================
+ Coverage          43.22%   43.28%   +0.06%     
  Complexity          8144     8144              
=================================================
  Files                548      548              
  Lines              42532    42542      +10     
=================================================
+ Hits               18383    18416      +33     
+ Misses             24149    24126      -23
Impacted Files Coverage Δ Complexity Δ
ext/test/optimizers/strreplace.zep.c 17.12% <0%> (ø) 0 <0> (ø) ⬇️
ext/test/fibonnaci.zep.c 66.92% <0%> (ø) 0 <0> (ø) ⬇️
ext/test/factorial.zep.c 7.14% <0%> (ø) 0 <0> (ø) ⬇️
ext/test/assign.zep.c 43.32% <0%> (ø) 0 <0> (ø) ⬇️
ext/test/spectralnorm.zep.c 1.25% <0%> (ø) 0 <0> (ø) ⬇️
Library/Compiler.php 61.38% <0%> (ø) 298 <0> (ø) ⬇️
Library/Code/Builder/Struct.php 0% <0%> (ø) 36 <0> (ø) ⬇️
ext/test/resourcetest.zep.c 78.84% <0%> (ø) 0 <0> (ø) ⬇️
ext/test/range.zep.c 10.34% <0%> (ø) 0 <0> (ø) ⬇️
ext/test/quantum.zep.c 1.79% <0%> (ø) 0 <0> (ø) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f03447...848a22c. Read the comment docs.

@AlexNDRmac
Copy link
Member Author

@dreamsxin you were right :) I did't do the tests correctly. Thank you for your participation.

@AlexNDRmac AlexNDRmac changed the title [WIP] BugFix | #1604 | Duplicate extension key prefix BugFix | #1604 | Duplicate extension key prefix Feb 19, 2019
@sergeyklay sergeyklay merged commit c599eb9 into development Feb 19, 2019
@sergeyklay sergeyklay deleted the bugfix/issue-1604 branch February 19, 2019 15:37
@sergeyklay
Copy link
Member

Thank you

@sergeyklay sergeyklay restored the bugfix/issue-1604 branch February 20, 2019 16:56
@sergeyklay sergeyklay deleted the bugfix/issue-1604 branch June 19, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants