Do not dump config file if config was changed #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually we need dump configuration exactly once - at project initialization. There are no needs to dump it for every config change. Also, this patch removes `Config::$changed` variable that is no longer needed.
Codecov Report
@@ Coverage Diff @@
## development #2035 +/- ##
=================================================
- Coverage 35.62% 35.62% -0.01%
- Complexity 8213 8216 +3
=================================================
Files 562 562
Lines 45316 45330 +14
=================================================
+ Hits 16146 16149 +3
- Misses 29170 29181 +11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Usually we need dump configuration exactly once - at project initialization. There are no needs to dump it for every config change. Also, this patch removes
Config::$changedvariable that is no longer needed.Thanks