Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .travis.yml. #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a .travis.yml. #5

wants to merge 1 commit into from

Conversation

davidben
Copy link
Contributor

Let's see if this works...

@davidben
Copy link
Contributor Author

@krawthekrow, it looks like the zephyr-go tests broke at some point. :-( I'm reproducing it locally too in the TestConnection* tests. Going to poke a bit, but you may have more time than me.

My current guess is the mess of mock servers and stuff I wrote way back is buggy.

@krawthekrow
Copy link
Contributor

Yeah, the tests didn't work when I ran them. They do work occasionally though, and the problem appears in multiple tests (but only among the connection tests), so I do believe that it has something to do with the mock servers. I wouldn't be debugging it this week, but I could look into it next time.

@davidben
Copy link
Contributor Author

Aha, I think I've found the bug. The mock timeouts business doesn't actually work right.

@davidben
Copy link
Contributor Author

I think 2013 me was a bit overeager in playing with goroutines and channels. I'll ponder how to fix this over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants