Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32l151xb: add missing SPI_CR2_FRF definitions #22

Merged

Conversation

karlp
Copy link
Contributor

@karlp karlp commented Oct 6, 2019

This is a bug in upstream CMSIS, but I don't have any contacts to get it
fixed there.

Signed-off-by: Karl Palsson karlp@etactica.com

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update stm32cube/stm32l1xx/README
ST Bug tracker ID: 73643

This is a bug in upstream CMSIS, but I don't have any contacts to get it
fixed there.

Fixes ST Bug: 73643

Signed-off-by: Karl Palsson <karlp@etactica.com>
@karlp
Copy link
Contributor Author

karlp commented Oct 10, 2019

I have attempted to do so for you, but given that I have no way of knowing those details ahead of time, I feel like this is something that project maintainers should do on merge. Let me know if you want me to re-word it further.

@erwango
Copy link
Member

erwango commented Oct 11, 2019

I have attempted to do so for you, but given that I have no way of knowing those details ahead of time, I feel like this is something that project maintainers should do on merge. Let me know if you want me to re-word it further.

Sure, this was indeed waiting for my action.
Thanks for the update.

erwango added a commit to erwango/zephyr that referenced this pull request Oct 11, 2019
Use zephyrproject-rtos/hal_stm32#22


Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
@MaureenHelm MaureenHelm merged commit 886636e into zephyrproject-rtos:master Oct 11, 2019
karlp added a commit to etactica/zephyr that referenced this pull request Oct 16, 2019
See also zephyrproject-rtos/hal_stm32#22

Signed-off-by: Karl Palsson <karlp@etactica.com>
MaureenHelm pushed a commit to zephyrproject-rtos/zephyr that referenced this pull request Oct 16, 2019
See also zephyrproject-rtos/hal_stm32#22

Signed-off-by: Karl Palsson <karlp@etactica.com>
@erwango
Copy link
Member

erwango commented May 11, 2020

@karlp, we had a late feedback from design to inform us that stm32l151xb stm32l151xa don't support this bit.
Can you confirm you actually need these definitions ?

@karlp
Copy link
Contributor Author

karlp commented May 17, 2020

That's correct, but not actually relevant. The user should not attempt to use this feature on a cat1/cat2 device, but the driver code attempts to clear the bit, (safe and marked as zero on cat1/cat2) and without the definitions it simply doesn't even compile. This was what my original commit message says. unless you want to change the driver to only attempt to set/clear the bit based on the availability of the bit, but that's a different path altogether.

@erwango
Copy link
Member

erwango commented May 18, 2020

Txs for clarification, I forgot about the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants