-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32l151xb: add missing SPI_CR2_FRF definitions #22
stm32l151xb: add missing SPI_CR2_FRF definitions #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update stm32cube/stm32l1xx/README
ST Bug tracker ID: 73643
This is a bug in upstream CMSIS, but I don't have any contacts to get it fixed there. Fixes ST Bug: 73643 Signed-off-by: Karl Palsson <karlp@etactica.com>
474ebad
to
5a8dc31
Compare
I have attempted to do so for you, but given that I have no way of knowing those details ahead of time, I feel like this is something that project maintainers should do on merge. Let me know if you want me to re-word it further. |
Sure, this was indeed waiting for my action. |
Use zephyrproject-rtos/hal_stm32#22 Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
See also zephyrproject-rtos/hal_stm32#22 Signed-off-by: Karl Palsson <karlp@etactica.com>
See also zephyrproject-rtos/hal_stm32#22 Signed-off-by: Karl Palsson <karlp@etactica.com>
@karlp, we had a late feedback from design to inform us that stm32l151xb stm32l151xa don't support this bit. |
That's correct, but not actually relevant. The user should not attempt to use this feature on a cat1/cat2 device, but the driver code attempts to clear the bit, (safe and marked as zero on cat1/cat2) and without the definitions it simply doesn't even compile. This was what my original commit message says. unless you want to change the driver to only attempt to set/clear the bit based on the availability of the bit, but that's a different path altogether. |
Txs for clarification, I forgot about the context. |
This is a bug in upstream CMSIS, but I don't have any contacts to get it
fixed there.
Signed-off-by: Karl Palsson karlp@etactica.com