Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm-generic-fdt machine support in qemu-system-aarch64 #136

Conversation

stephanosio
Copy link
Member

This commit adds a patch to support the arm-generic-fdt machine type
in qemu-system-aarch64. The arm-generic-fdt machine type is currently
available only in the Xilinx QEMU fork and this patch was generated by
diff-ing the QEMU 4.1 release and the master_next branch of the Xilinx
fork (which is based on the QEMU 4.1 release).

This machine type is required to properly emulate the Xilinx Zynq SoCs
used by the qemu_cortex_r5 platform.

For more details, refer to the issue #132.

Signed-off-by: Stephanos Ioannidis root@stephanos.io

This closes #132.

@stephanosio stephanosio force-pushed the add_aarch64_arm_generic_fdt branch 2 times, most recently from bb9daa8 to 6081b8a Compare October 30, 2019 14:47
This commit adds a patch to support the arm-generic-fdt machine type
in qemu-system-aarch64. The arm-generic-fdt machine type is currently
available only in the Xilinx QEMU fork and this patch was generated by
diff-ing the QEMU 4.1 release and the master_next branch of the Xilinx
fork (which is based on the QEMU 4.1 release).

This machine type is required to properly emulate the Xilinx Zynq SoCs
used by the qemu_cortex_r5 platform.

For more details, refer to the issue zephyrproject-rtos#132.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
Copy link
Contributor

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than pulling a huge patch, can we build the arm-generic-fdt as a separate package and point to the xilinx git tree?

I'm concerned about what impact having this huge change has on all the other qemu builds.

@stephanosio
Copy link
Member Author

Rather than pulling a huge patch, can we build the arm-generic-fdt as a separate package and point to the xilinx git tree?

I thought of doing that initially, but it seemed like that would subsequently require quite a few other changes, so I went with this (e.g. updating Zephyr build system to support multiple QEMU versions and potentially restructuring some qemu-related stuff in sdk-ng too).

Most of the changes in the Xilinx repo have to do with only ARM and the peripherals used by the Xilinx SoCs, so the I would expect the impact on other archs to be minimal.

I have run Zephyr test suite for all archs using the patched QEMU and they all seem to be working properly.

If you still prefer to have Xilinx QEMU as a separate package, I will close this PR and create a new one for that.

@galak
Copy link
Contributor

galak commented Oct 31, 2019

I thought of doing that initially, but it seemed like that would subsequently require quite a few other changes, so I went with this (e.g. updating Zephyr build system to support multiple QEMU versions and potentially restructuring some qemu-related stuff in sdk-ng too).

Most of the changes in the Xilinx repo have to do with only ARM and the peripherals used by the Xilinx SoCs, so the I would expect the impact on other archs to be minimal.

I have run Zephyr test suite for all archs using the patched QEMU and they all seem to be working properly.

I'm also concerned that this couples us to Xilinx release/update cadence for all other qemu platforms. I know there are number of changes Xilinx makes to QEMU that the upstream community hasn't been keen on accepted.

If you still prefer to have Xilinx QEMU as a separate package, I will close this PR and create a new one for that.

If you would that would be appreciated.

@stephanosio
Copy link
Member Author

Superseded by #138.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add arm-generic-fdt machine support in qemu-system-aarch64
2 participants