Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segger: update to 3.40 #15

Merged
merged 1 commit into from
May 19, 2023
Merged

segger: update to 3.40 #15

merged 1 commit into from
May 19, 2023

Conversation

sigvartmh
Copy link
Contributor

Update to 3.40 of SystemView Target sources.

Signed-off-by: Sigvart Hovland sigvart.hovland@nordicsemi.no

@sigvartmh
Copy link
Contributor Author

sigvartmh commented Dec 21, 2022 •
edited

@carlescufi @nashif Couldn't add you to reviewers I don't seem to have access. I'll make a dos2unix conversion PR after this is merged so that it will be a lot easier to do diffs. Currently some DOS newlines ^M have been removed from some strings making it a mess to diff, edit and update so my suggestion is to convert the source to UNIX so that it's standardized and better handled by git on any platform.

Dos2unix PR: #16

@sigvartmh
Copy link
Contributor Author

Also haven't made the Zephyr Update PR yet.

@sigvartmh sigvartmh force-pushed the segger-sysview-3.40 branch 2 times, most recently from 4e375b8 to 451c8e3 Compare December 21, 2022 14:47
@brycewilkins brycewilkins mentioned this pull request Dec 22, 2022
Closed
carlescufi
carlescufi approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@carlescufi
Copy link
Member

@sigvartmh did you also update this part: #14 ?

@sigvartmh
Copy link
Contributor Author

@carlescufi No I'll look into adding it 👍

@carlescufi
Copy link
Member

@carlescufi No I'll look into adding it 👍

Thanks! It might be that it doesn't require an update, but just in case!

@sigvartmh sigvartmh force-pushed the segger-sysview-3.40 branch 3 times, most recently from 023927d to 8580009 Compare January 3, 2023 12:13
@sigvartmh
Copy link
Contributor Author

@carlescufi Went through and checked if there were any changes to #14 and it was only minor commented out code and some line changes. Added it but can be removed.

@sigvartmh
Copy link
Contributor Author

@nashif Any feedback?

@MaureenHelm
Copy link
Member

Also haven't made the Zephyr Update PR yet.

We need this for CI

@zephyrbot zephyrbot mentioned this pull request Mar 30, 2023
Merged
@sigvartmh
segger: update to 3.40
4c34cde 
Update to 3.40 of SystemView Target sources.

Signed-off-by: Sigvart Hovland <sigvart.hovland@nordicsemi.no>
@carlescufi carlescufi merged commit 5792675 into zephyrproject-rtos:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@carlescufi carlescufi carlescufi approved these changes

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sigvartmh @carlescufi @MaureenHelm