zephyr: Aligning source directory tree with apache/mynewt-core #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal of this commit is to make file structure tree, of this fork of TinyCBOR, to be more aligned to the upstream: https://github.com/apache/mynewt-core/tree/master/encoding/tinycbor Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
|
@de-nordic Can you provide path to the zephyr west.yaml https://docs.zephyrproject.org/latest/guides/modules.html#changes-to-existing-modules and any code adaptation needed? |
|
@nvlsianpu synchronous modification of zephyr source code is not needed for now, as there is redundant path provided that makes old includes work within zephyr (in CMakeLists.txt). Such changes may be completed lately. Redundant path may be removed lately as there is more work needed within TinyCBOR code alignment. |
|
@nvlsianpu west.yml update: zephyrproject-rtos/zephyr#19876 |
vrahane
approved these changes
Oct 17, 2019
de-nordic
changed the title
nvlsianpu
approved these changes
Oct 17, 2019
|
@carlescufi this is ready to be merged |
carlescufi
changed the title
de-nordic
added a commit
to de-nordic/zephyr
that referenced
this pull request
Oct 21, 2019
Reviewed here: zephyrproject-rtos/tinycbor#8 Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
galak
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Oct 22, 2019
Reviewed here: zephyrproject-rtos/tinycbor#8 Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this commit is to make file structure tree, of this fork of
TinyCBOR, to be more aligned to the upstream:
https://github.com/apache/mynewt-core/tree/master/encoding/tinycbor
Signed-off-by: Dominik Ermel dominik.ermel@nordicsemi.no