Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates window box default parameters and regenerates clinic headers for py312. #53

Merged
merged 1 commit into from
May 5, 2024

Conversation

gotyaoi
Copy link
Contributor

@gotyaoi gotyaoi commented May 5, 2024

Fixes #50.

@stephanosio
Copy link
Member

@gotyaoi #54 fixed the Python 3.10-3.12 CI issues. Could you rebase?

Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we will need to update the README to say:

  1. Avoid manually modifying clinic header files.
  2. Run clinic.py on _cursesmodule.c and _curses_panel.c after applying patches.

I will post a follow-up PR doing that.

By the way, I have noticed that the files under the py312 directory were simply copied over from py311 without following the process described in the README, which explains why there are so many header file changes in this PR.

A more complete fix should involve copying _cursesmodule.c and _curses_panel.c from the Python 3.12 tree, applying the windows-curses-specific patches and running clinic.py on them to generate headers.

For now, I will merge this PR as-is and make a new release. If there are still more problems, I will look into implementing the more-complete fix described above.

@stephanosio stephanosio merged commit f0193a2 into zephyrproject-rtos:main May 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setupterm exit silently on Python 3.12
2 participants