Skip to content

Commit

Permalink
ipc: Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Kamil Gawor <40163811+KAGA164@users.noreply.github.com>
Co-authored-by: Dominik Chat <dominik.chat@nordicsemi.no>
  • Loading branch information
3 people committed Jun 6, 2023
1 parent 352b482 commit 5da0ba6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion subsys/ipc/ipc_service/backends/Kconfig
Expand Up @@ -56,7 +56,7 @@ config IPC_SERVICE_BACKEND_ICMSG_WITH_BUF
select IPC_SERVICE_ICMSG
help
Choosing this backend results in multi endpoint implementation based
on dynamically allocated buffers. References to them are send over
on dynamically allocated buffers. References to them are sent over
ICMsg circular buffer.

rsource "Kconfig.icmsg_me"
Expand Down
2 changes: 1 addition & 1 deletion subsys/ipc/ipc_service/backends/Kconfig.icmsg_with_buf
Expand Up @@ -4,7 +4,7 @@
if IPC_SERVICE_BACKEND_ICMSG_WITH_BUF

config IPC_SERVICE_BACKEND_ICMSG_WITH_BUF_NUM_EP
int "Endpoints number"
int "Endpoints count"
range 1 251
default 4
help
Expand Down
6 changes: 3 additions & 3 deletions subsys/ipc/ipc_service/backends/ipc_icmsg_with_buf.c
Expand Up @@ -137,7 +137,7 @@ struct icmsg_with_buf_config {
struct channel_config rx; /* RX channel config. */
struct channel_config tx; /* RX channel config. */
sys_bitarray_t *tx_usage_bitmap; /* Bit is set when TX block is in use */
sys_bitarray_t *rx_hold_bitmap; /* Bit is set is buffer starting at this
sys_bitarray_t *rx_hold_bitmap; /* Bit is set, if buffer starting at this
* block should be kept after exit from
* receive handler.
*/
Expand Down Expand Up @@ -167,7 +167,7 @@ struct backend_data {
* registered locally.
*/
uint8_t ept_count; /* Number of registered endpoints. */
bool icmsg_bounded; /* ISmsg was bounded already. */
bool icmsg_bounded; /* ICMsg was bounded already. */
};

struct block_header {
Expand Down Expand Up @@ -479,7 +479,7 @@ static int icmsg_send_wrapper(struct backend_data *dev_data, uint8_t addr_or_msg
}

/**
* Release received buffer. This function will just sends release message over ICMsg.
* Release received buffer. This function will just send release message over ICMsg.
*
* @param[in] buffer Buffer to release
* @param[in] msg_type Message type: MSG_RELEASE_BOUND or MSG_RELEASE_DATA
Expand Down

0 comments on commit 5da0ba6

Please sign in to comment.