Skip to content

Commit

Permalink
debug: coredump: Move COREDUMP_*_STR strings to the public header
Browse files Browse the repository at this point in the history
This allows a customized coredump_backend_other API to re-use the
COREDUMP_*_STR without re-defining the same strings.

Signed-off-by: Younghyun Park <younghyunpark@google.com>
  • Loading branch information
myguitar authored and nashif committed May 25, 2024
1 parent 2d665c1 commit ea29ef3
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 10 deletions.
13 changes: 13 additions & 0 deletions include/zephyr/debug/coredump.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,19 @@
#include <stdint.h>
#include <sys/types.h>

/*
* Define COREDUMP_*_STR as public to allow coredump_backend_other to re-use
* these strings if necessary
*/
#define COREDUMP_BEGIN_STR "BEGIN#"
#define COREDUMP_END_STR "END#"
#define COREDUMP_ERROR_STR "ERROR CANNOT DUMP#"

/*
* Need to prefix coredump strings to make it easier to parse
* as log module adds its own prefixes.
*/
#define COREDUMP_PREFIX_STR "#CD:"

/**
* @file
Expand Down
10 changes: 0 additions & 10 deletions subsys/debug/coredump/coredump_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,6 @@
* public documentation.
*/

#define COREDUMP_BEGIN_STR "BEGIN#"
#define COREDUMP_END_STR "END#"
#define COREDUMP_ERROR_STR "ERROR CANNOT DUMP#"

/*
* Need to prefix coredump strings to make it easier to parse
* as log module adds its own prefixes.
*/
#define COREDUMP_PREFIX_STR "#CD:"

struct z_coredump_memory_region_t {
uintptr_t start;
uintptr_t end;
Expand Down

0 comments on commit ea29ef3

Please sign in to comment.